From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59270C433E0 for ; Tue, 23 Jun 2020 21:04:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30A5320663 for ; Tue, 23 Jun 2020 21:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592946274; bh=FH1Dcw5Wq2cpP9b9ZjB+7wg00CxQ4WqhkoJEEmdu6Zc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=phnlVulccKvVgm6mH5WLBsn2chXOapAcAZ6GezKV5IA9sHWw8SQYJ2QS/sxvcAyTj F0Ys8a/OHJ+xge40uxkYwbG1IlcDx6jWmE/C7RO2HuEHzRTMrglDR18W35ZC6HdXo0 U1FiXmLx4H6D0c2eiqUGQqOQIb9Fod05PTKMiaJE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389669AbgFWVEc (ORCPT ); Tue, 23 Jun 2020 17:04:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:33258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388289AbgFWUhz (ORCPT ); Tue, 23 Jun 2020 16:37:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41DC521582; Tue, 23 Jun 2020 20:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944675; bh=FH1Dcw5Wq2cpP9b9ZjB+7wg00CxQ4WqhkoJEEmdu6Zc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cRXx6goyel29eOfqZY3GCWZqPmf5Txs83PdM32euiunS6DnAlIcv99ruDGggfWcuZ DQ+0ej4EQM3fz7yvmJJbxLh+mv4vWkr9hMu3g07SLwk7ktf4BxidPY7BOGzSItRZEm UG251P7xuwSdLYST299j+zPCT8Ww997TSr0AV8nI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Tero Kristo , Tony Lindgren , Stephen Boyd , Sasha Levin Subject: [PATCH 4.19 081/206] clk: ti: composite: fix memory leak Date: Tue, 23 Jun 2020 21:56:49 +0200 Message-Id: <20200623195320.924648305@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195316.864547658@linuxfoundation.org> References: <20200623195316.864547658@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tero Kristo [ Upstream commit c7c1cbbc9217ebb5601b88d138d4a5358548de9d ] The parent_names is never released for a component clock definition, causing some memory leak. Fix by releasing it once it is no longer needed. Reported-by: Tomi Valkeinen Signed-off-by: Tero Kristo Link: https://lkml.kernel.org/r/20200429131341.4697-2-t-kristo@ti.com Acked-by: Tony Lindgren Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/composite.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/ti/composite.c b/drivers/clk/ti/composite.c index 030e8b2c10500..c6478d0b996b2 100644 --- a/drivers/clk/ti/composite.c +++ b/drivers/clk/ti/composite.c @@ -196,6 +196,7 @@ cleanup: if (!cclk->comp_clks[i]) continue; list_del(&cclk->comp_clks[i]->link); + kfree(cclk->comp_clks[i]->parent_names); kfree(cclk->comp_clks[i]); } -- 2.25.1