From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD0BC433E0 for ; Tue, 23 Jun 2020 21:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1003720663 for ; Tue, 23 Jun 2020 21:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592946036; bh=oJkClXDsc+BFX9zqlVqiRoKbvg0UyAY5buTFGfmxtzk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mdx5w3bgx0BwI8YgVFLQW2bmdHKPTr+RAxTNroAWIjScT/ea3quNsp4WolfI0HYSy Co2M6QX9Ol5av/GQu0X5R57NbIxrc9dt55AWdnO8gsfuvqgovA1OxuX7QLdO60xdkT Q5iMFBIJa359auOXG3x1r9tMCkUzdU2PYHilM6qE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392158AbgFWUkN (ORCPT ); Tue, 23 Jun 2020 16:40:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:36100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392161AbgFWUkL (ORCPT ); Tue, 23 Jun 2020 16:40:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1B61218AC; Tue, 23 Jun 2020 20:40:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944812; bh=oJkClXDsc+BFX9zqlVqiRoKbvg0UyAY5buTFGfmxtzk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0+gc2pLcQOnd4H59PjtIkTth6NyzOD8uet720o0vy7XNpHPKgtnEdHbCYN5uUaIcq 7CSQeN77nhxE5MByey37VaOr1f7j0HsUC0+DZJEirgiZiya/g5udh7bu+fmkHfWu6+ 28teQExSyef5LUv3N+ORrKhebXFNzj6otqFS5ZDA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stafford Horne , Sasha Levin Subject: [PATCH 4.19 127/206] openrisc: Fix issue with argument clobbering for clone/fork Date: Tue, 23 Jun 2020 21:57:35 +0200 Message-Id: <20200623195323.224925073@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195316.864547658@linuxfoundation.org> References: <20200623195316.864547658@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Stafford Horne [ Upstream commit 6bd140e14d9aaa734ec37985b8b20a96c0ece948 ] Working on the OpenRISC glibc port I found that sometimes clone was working strange. That the tls data argument sent in r7 was always wrong. Further investigation revealed that the arguments were getting clobbered in the entry code. This patch removes the code that writes to the argument registers. This was likely due to some old code hanging around. This patch fixes this up for clone and fork. This fork clobber is harmless but also useless so remove. Signed-off-by: Stafford Horne Signed-off-by: Sasha Levin --- arch/openrisc/kernel/entry.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/openrisc/kernel/entry.S b/arch/openrisc/kernel/entry.S index ee6159d2ed22e..01b59d2ce1747 100644 --- a/arch/openrisc/kernel/entry.S +++ b/arch/openrisc/kernel/entry.S @@ -1170,13 +1170,13 @@ ENTRY(__sys_clone) l.movhi r29,hi(sys_clone) l.ori r29,r29,lo(sys_clone) l.j _fork_save_extra_regs_and_call - l.addi r7,r1,0 + l.nop ENTRY(__sys_fork) l.movhi r29,hi(sys_fork) l.ori r29,r29,lo(sys_fork) l.j _fork_save_extra_regs_and_call - l.addi r3,r1,0 + l.nop ENTRY(sys_rt_sigreturn) l.jal _sys_rt_sigreturn -- 2.25.1