From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96D21C433DF for ; Tue, 23 Jun 2020 21:38:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 650A42072E for ; Tue, 23 Jun 2020 21:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592948293; bh=EVGNaU5UG4oA/uwZM3rA7fS15ONY1TY9nLQmc0Ij++4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1dGbQ5o85JPvRH3RZ030DYx1Bfh80Nms2d9O80E03Gh7gcmG0IpWC1PSl7zWW6kJr DwiJ/j+sP6vXTa9ZhKaOhwyYv1v/LkAJsKXyOUPPldgbCW7MiWBFmaNWrItzmiP2rq ZogPT7QG4GQ4btZserqT0AANTx/vxhAjZ+oCAQwE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388313AbgFWViM (ORCPT ); Tue, 23 Jun 2020 17:38:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:49466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388025AbgFWUIa (ORCPT ); Tue, 23 Jun 2020 16:08:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1E39206C3; Tue, 23 Jun 2020 20:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592942910; bh=EVGNaU5UG4oA/uwZM3rA7fS15ONY1TY9nLQmc0Ij++4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cqVkwMW5v/VFKxBfvEhhwT3lm6HVGFBWYVw4KMQb87LYHBaqw8BLwDk4DR7ycdDBF hX39M5y8N+S6l19GBXSOadAwulFKCXWBefdR7UxSsVuQitIYh0PzniqM39MpG50xPQ Bc/MVE5zfs4VaKc3e+6EuDb9pnitPHk7fPmpGqvk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Suganath Prabu S , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.7 184/477] scsi: mpt3sas: Fix double free warnings Date: Tue, 23 Jun 2020 21:53:01 +0200 Message-Id: <20200623195416.284235028@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195407.572062007@linuxfoundation.org> References: <20200623195407.572062007@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Suganath Prabu S [ Upstream commit cbbfdb2a2416c9f0cde913cf09670097ac281282 ] Fix following warning from Smatch static analyser: drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools() warn: 'ioc->hpr_lookup' double freed drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools() warn: 'ioc->internal_lookup' double freed Link: https://lore.kernel.org/r/20200508110738.30732-1-suganath-prabu.subramani@broadcom.com Reported-by: Dan Carpenter Signed-off-by: Suganath Prabu S Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 663782bb790dc..39d233262039e 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -4915,7 +4915,9 @@ _base_release_memory_pools(struct MPT3SAS_ADAPTER *ioc) } kfree(ioc->hpr_lookup); + ioc->hpr_lookup = NULL; kfree(ioc->internal_lookup); + ioc->internal_lookup = NULL; if (ioc->chain_lookup) { for (i = 0; i < ioc->scsiio_depth; i++) { for (j = ioc->chains_per_prp_buffer; -- 2.25.1