From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7517BC433DF for ; Tue, 23 Jun 2020 21:30:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44F4720781 for ; Tue, 23 Jun 2020 21:30:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592947842; bh=5sWbhd69f98lLETBFKDPvPfYfT9N6UYvfFQw0X5a4eU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uEPDFxHRHVjcSd4+osZY4q4bD/Om8S3g+PnLZJthBXbPCRP5RnFKhT+6QXy27S6qx xg22u8gabxQ//r60N9GVFbceghfXrrwBCAxb1SKZKtQ86P5UcIiTKUrKNh2TUHjUoJ NcCThm0F3RLCULFmqNjSfEZyJn9/7ksZxe7o498A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389116AbgFWVah (ORCPT ); Tue, 23 Jun 2020 17:30:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:55754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389105AbgFWUNh (ORCPT ); Tue, 23 Jun 2020 16:13:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAA22206C3; Tue, 23 Jun 2020 20:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592943217; bh=5sWbhd69f98lLETBFKDPvPfYfT9N6UYvfFQw0X5a4eU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ek661p1ckarKo+GmTW0nh2JsHGAqjtCR7Ao0Q1Iu3bqg03E9e9kEWvl9LrXvO1QNl K5GH63jdfNJslkciu58yFC+9iyIQBzMIWReW1Lqa8jgfIkLllpjP6PBqaRomgAxGnf 6bQzgZSdT3em/ZjAQ334HfU1STHk3DZk86+GSD0w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qiushi Wu , Mark Brown , Sasha Levin Subject: [PATCH 5.7 275/477] ASoC: fix incomplete error-handling in img_i2s_in_probe. Date: Tue, 23 Jun 2020 21:54:32 +0200 Message-Id: <20200623195420.563174993@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195407.572062007@linuxfoundation.org> References: <20200623195407.572062007@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Qiushi Wu [ Upstream commit 25bf943e4e7b47282bd86ae7d39e039217ebb007 ] Function "pm_runtime_get_sync()" is not handled by "pm_runtime_put()" if "PTR_ERR(rst) == -EPROBE_DEFER". Fix this issue by adding "pm_runtime_put()" into this error path. Fixes: f65bb92ca12e ("ASoC: img-i2s-in: Add runtime PM") Signed-off-by: Qiushi Wu Link: https://lore.kernel.org/r/20200525055011.31925-1-wu000273@umn.edu Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/img/img-i2s-in.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c index a495d1050d490..e30b66b94bf67 100644 --- a/sound/soc/img/img-i2s-in.c +++ b/sound/soc/img/img-i2s-in.c @@ -482,6 +482,7 @@ static int img_i2s_in_probe(struct platform_device *pdev) if (IS_ERR(rst)) { if (PTR_ERR(rst) == -EPROBE_DEFER) { ret = -EPROBE_DEFER; + pm_runtime_put(&pdev->dev); goto err_suspend; } -- 2.25.1