From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98714C433DF for ; Tue, 23 Jun 2020 21:29:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CAA220724 for ; Tue, 23 Jun 2020 21:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592947787; bh=m0lTzWeXLAZAc+bQnl4RhpPa6XP8ASvh6Sn+D3s1Wy0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=CTFmTk4J678ZHbs7wtpLyiodFFeuXFJ8qqTY0+5lp9efaUPPUSw4021/Bexz3zP5f sHiLnZk1ujP3CG4m6CkjM1VjU+r4CrF/9c6kblNQTFVRc1pZn3RXEuOYfRe9ZrCXLP 5RlJmhaSxGhWgW98FTxQq7l3RLB00zwGZcMZuc6E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389230AbgFWUOr (ORCPT ); Tue, 23 Jun 2020 16:14:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:57248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389222AbgFWUOn (ORCPT ); Tue, 23 Jun 2020 16:14:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6ED0F2078A; Tue, 23 Jun 2020 20:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592943283; bh=m0lTzWeXLAZAc+bQnl4RhpPa6XP8ASvh6Sn+D3s1Wy0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w/zdewR9C/40CfIC0uGDU4T9mDoXnLEPpLG9aUxm87qn0vGNDRnyeaB7fnDhx94kT 7mj6cqYrJuC4E5k/hTN+OfSOPDHAN54cK5wOemZknTLQ5aGpCU4wMkKn5cLzMlz+Ny xgfNtrmrqUb5iwgtPgfv72GWAeVt7dCDehQ4w+Kg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ram Pai , Sandipan Das , Andrew Morton , Dave Hansen , Florian Weimer , "Desnes A. Nunes do Rosario" , Ingo Molnar , Thiago Jung Bauermann , "Aneesh Kumar K.V" , Michael Ellerman , Michal Hocko , Michal Suchanek , Shuah Khan , Linus Torvalds , Sasha Levin Subject: [PATCH 5.7 330/477] selftests/vm/pkeys: fix alloc_random_pkey() to make it really random Date: Tue, 23 Jun 2020 21:55:27 +0200 Message-Id: <20200623195423.137676549@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195407.572062007@linuxfoundation.org> References: <20200623195407.572062007@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Ram Pai [ Upstream commit 6e373263ce07eeaa6410843179535fbdf561fc31 ] alloc_random_pkey() was allocating the same pkey every time. Not all pkeys were geting tested. This fixes it. Signed-off-by: Ram Pai Signed-off-by: Sandipan Das Signed-off-by: Andrew Morton Acked-by: Dave Hansen Cc: Dave Hansen Cc: Florian Weimer Cc: "Desnes A. Nunes do Rosario" Cc: Ingo Molnar Cc: Thiago Jung Bauermann Cc: "Aneesh Kumar K.V" Cc: Michael Ellerman Cc: Michal Hocko Cc: Michal Suchanek Cc: Shuah Khan Link: http://lkml.kernel.org/r/0162f55816d4e783a0d6e49e554d0ab9a3c9a23b.1585646528.git.sandipan@linux.ibm.com Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- tools/testing/selftests/x86/protection_keys.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/x86/protection_keys.c b/tools/testing/selftests/x86/protection_keys.c index 480995bceefa5..47191af466174 100644 --- a/tools/testing/selftests/x86/protection_keys.c +++ b/tools/testing/selftests/x86/protection_keys.c @@ -24,6 +24,7 @@ #define _GNU_SOURCE #include #include +#include #include #include #include @@ -612,10 +613,10 @@ int alloc_random_pkey(void) int nr_alloced = 0; int random_index; memset(alloced_pkeys, 0, sizeof(alloced_pkeys)); + srand((unsigned int)time(NULL)); /* allocate every possible key and make a note of which ones we got */ max_nr_pkey_allocs = NR_PKEYS; - max_nr_pkey_allocs = 1; for (i = 0; i < max_nr_pkey_allocs; i++) { int new_pkey = alloc_pkey(); if (new_pkey < 0) -- 2.25.1