From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1933C433E0 for ; Sat, 27 Jun 2020 18:22:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E51220760 for ; Sat, 27 Jun 2020 18:22:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gy42z+6c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726695AbgF0SWd (ORCPT ); Sat, 27 Jun 2020 14:22:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbgF0SWb (ORCPT ); Sat, 27 Jun 2020 14:22:31 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A01D2C03E979 for ; Sat, 27 Jun 2020 11:22:30 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id e13so11840724qkg.5 for ; Sat, 27 Jun 2020 11:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wknXL/NZZBsk//od0+ACYvlDvjjEXtFODMTp/oomwis=; b=gy42z+6cy8ul5JraOk9jo44rONTJWYOz8zCY+b1cDGhklC9x1j9JQleDZ+cDg9XKIz kOLCc87SIQaieB795ZhReKG4MCPphuoFynjteK/os1Ff9I7E33uDizZD3UmQB4rk8vUB p3ucSkV7E4bPsKeajNlQ/T66NtHKQKCePNhLfDa4jkTinDcvVk41/7hnQ/gwwBftf8At MhFNLNGvzZHPnvwyUdzdhwDbJKblAAu5vuTFlx2ogyCElXnHjMiePc2f4fe6GwVYCcDv OCn1r4Gm1EIpUvW1CXvE3DEhKg7ed6aif/tw1n8Bh1mITbsMrH8uvDMQb8KDCPJk+H93 Scsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wknXL/NZZBsk//od0+ACYvlDvjjEXtFODMTp/oomwis=; b=iGjx45IVQH7Msq1JbbFYc9d7Zb62sCZXXznMTp14H/U/iMAKbSl6sOseArtC62ivgX v9J1W+x+9jaPb5PEaF0tkDVCfH7EBH8zViyLQhOD9t0O1Eqphrf8w0UNKg0XuJm3kMuC zWoRBOIm3EAFXZK13B9ulYnM4NQzKxXua+yxN0gOyi6ZxtD57h+NeqKjVxnw3Zv2d42i QYGNqH7E1bUbhiLeZyNszmm9I6LsT+7deSw2YxoA/vK17wMIjxrYfyhgR3RXeW6mIsVa bgqjNP+wL1ycHHKlecevfn/J/aIrHql7czEdDh9Juwpd/LXp7ai4xSgkeelO4mFOB5wC jM8A== X-Gm-Message-State: AOAM533obouZOLC6Xnh9B/KO8x2ineHvmjI1tE/8N1ihe1afrkeMkkIZ w1LZGWDGvQxip2CXjoAmEF9gXw== X-Google-Smtp-Source: ABdhPJyMXt2Ydo4dC6F+leoChRx/t4i2wi/giZ/uvjrThjMGzcC5n4fP3Y0B6gfrNjz/A5fawt1+lQ== X-Received: by 2002:a05:620a:1275:: with SMTP id b21mr8233352qkl.4.1593282149751; Sat, 27 Jun 2020 11:22:29 -0700 (PDT) Received: from localhost (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id q5sm10310519qtf.12.2020.06.27.11.22.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 Jun 2020 11:22:29 -0700 (PDT) Date: Sat, 27 Jun 2020 14:22:28 -0400 From: Ralph Siemsen To: Sasha Levin Cc: Serge Semin , Pavel Machek , Serge Semin , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Thomas Bogendoerfer , Arnd Bergmann , Andy Shevchenko , Feng Tang , Rob Herring , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, Mark Brown Subject: Re: [PATCH 4.19 182/267] spi: dw: Return any value retrieved from the dma_transfer callback Message-ID: <20200627182228.GA23327@maple.netwinder.org> References: <20200619141648.840376470@linuxfoundation.org> <20200619141657.498868116@linuxfoundation.org> <20200619210719.GB12233@amd> <20200622205121.4xuki7guyj6u5yul@mobilestation> <20200626151800.GA22242@maple.netwinder.org> <20200626200710.GK1931@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200626200710.GK1931@sasha-vm> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Sasha, On Fri, Jun 26, 2020 at 04:07:10PM -0400, Sasha Levin wrote: >On Fri, Jun 26, 2020 at 11:18:00AM -0400, Ralph Siemsen wrote: >> >>So the following patch is needed as well, at least in 4.9 and 4.19, >>I did not check/test other versions. Mainline does not need this, >>since the code seems to have been refactored to avoid the >>duplication. > >Could you add your signed-off-by tag please? :) Whoops, for some reason I snipped it out... sorry about that! Here it is again, with the commit message tweaked for clarity. Subject: [PATCH] spi: dw: Fix return value of dma_transfer callback Earlier commit "spi: dw: Return any value retrieved from the dma_transfer callback" changed the return code of mid_spi_dma_transfer() from 0 to 1 in drivers/spi/spi-dw-mid.c. A similar change is needed spi-dw-mmio.c for mmio_spi_dma_transfer() function. Note this only applies to older branches, as mainline has refactored the code to avoid duplication. Signed-off-by: Ralph Siemsen --- drivers/spi/spi-dw-mmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c index c563c2815093..99641c485288 100644 --- a/drivers/spi/spi-dw-mmio.c +++ b/drivers/spi/spi-dw-mmio.c @@ -358,7 +358,7 @@ static int mmio_spi_dma_transfer(struct dw_spi *dws, struct spi_transfer *xfer) dma_async_issue_pending(dws->txchan); } - return 0; + return 1; } static void mmio_spi_dma_stop(struct dw_spi *dws) -- 2.17.1