Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: zhangxiaoxu5@huawei.com, hulkci@huawei.com,
	pshilov@microsoft.com, stfrench@microsoft.com,
	stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] cifs/smb3: Fix data inconsistent when zero file range" failed to apply to 4.19-stable tree
Date: Sun, 28 Jun 2020 18:08:15 -0400	[thread overview]
Message-ID: <20200628220815.GP1931@sasha-vm> (raw)
In-Reply-To: <159335944015982@kroah.com>

On Sun, Jun 28, 2020 at 05:50:40PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 6b69040247e14b43419a520f841f2b3052833df9 Mon Sep 17 00:00:00 2001
>From: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
>Date: Tue, 23 Jun 2020 07:31:54 -0400
>Subject: [PATCH] cifs/smb3: Fix data inconsistent when zero file range
>
>CIFS implements the fallocate(FALLOC_FL_ZERO_RANGE) with send SMB
>ioctl(FSCTL_SET_ZERO_DATA) to server. It just set the range of the
>remote file to zero, but local page cache not update, then the data
>inconsistent with server, which leads the xfstest generic/008 failed.
>
>So we need to remove the local page caches before send SMB
>ioctl(FSCTL_SET_ZERO_DATA) to server. After next read, it will
>re-cache it.
>
>Fixes: 30175628bf7f5 ("[SMB3] Enable fallocate -z support for SMB3 mounts")
>Reported-by: Hulk Robot <hulkci@huawei.com>
>Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
>Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
>Cc: stable@vger.kernel.org # v3.17
>Signed-off-by: Steve French <stfrench@microsoft.com>

Conflict with the tracepoint that didn't exist on older kernels. Fixed
up and queued for 4.19, 4.14, 4.9, and 4.4.

-- 
Thanks,
Sasha

      reply	other threads:[~2020-06-28 22:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28 15:50 FAILED: patch "[PATCH] cifs/smb3: Fix data inconsistent when zero file range" failed to apply to 4.19-stable tree gregkh
2020-06-28 22:08 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200628220815.GP1931@sasha-vm \
    --to=sashal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hulkci@huawei.com \
    --cc=pshilov@microsoft.com \
    --cc=stable@vger.kernel.org \
    --cc=stfrench@microsoft.com \
    --cc=zhangxiaoxu5@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox