From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D98C433E0 for ; Mon, 29 Jun 2020 19:30:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DE8B2065F for ; Mon, 29 Jun 2020 19:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593459039; bh=Jofg5uL56/LdgjP5jFN/MLCW+s24eX2YwTHGnd9iqk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Uwo+1RtcFM80sEUc5rl6r1swJEdJ2sztSxIu7meYqMIOklo9Mz+iP7D5KSSzqus57 MuWr2SD8zY8a2HYViAzZEc4c/LS1VCKBx2VEAmiEwcaXuzcOP9lsKNLbXxs7QTMkXZ 2RTPOXrr59Vt5bWrav91aO6pOVoA59zXLXsNGuMY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733029AbgF2Tah (ORCPT ); Mon, 29 Jun 2020 15:30:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:40572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733022AbgF2Taf (ORCPT ); Mon, 29 Jun 2020 15:30:35 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA97C2527E; Mon, 29 Jun 2020 15:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593444988; bh=Jofg5uL56/LdgjP5jFN/MLCW+s24eX2YwTHGnd9iqk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xI67r9+n7FZjzm7mYPlfkHzmUXYG0kAs4Wl9cNV5+8Eah1yEQFv4l9hoqALu7JTpw 71SxhLlYBgW7Qd3XEKNFIEqeDPSeVBfX4P7wGmSalmSXxCThzOmqyZk0I/7Eu1a8Nw J+fbMVAT8F/HduGN6LBBKHUPanxSrv1heVBNujgI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juri Lelli , syzbot+5ac8bac25f95e8b221e7@syzkaller.appspotmail.com, Peter Zijlstra , Ingo Molnar , Daniel Wagner , Sasha Levin Subject: [PATCH 4.19 088/131] sched/deadline: Initialize ->dl_boosted Date: Mon, 29 Jun 2020 11:34:19 -0400 Message-Id: <20200629153502.2494656-89-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200629153502.2494656-1-sashal@kernel.org> References: <20200629153502.2494656-1-sashal@kernel.org> MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.131-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-4.19.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 4.19.131-rc1 X-KernelTest-Deadline: 2020-07-01T15:34+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Juri Lelli [ Upstream commit ce9bc3b27f2a21a7969b41ffb04df8cf61bd1592 ] syzbot reported the following warning triggered via SYSC_sched_setattr(): WARNING: CPU: 0 PID: 6973 at kernel/sched/deadline.c:593 setup_new_dl_entity /kernel/sched/deadline.c:594 [inline] WARNING: CPU: 0 PID: 6973 at kernel/sched/deadline.c:593 enqueue_dl_entity /kernel/sched/deadline.c:1370 [inline] WARNING: CPU: 0 PID: 6973 at kernel/sched/deadline.c:593 enqueue_task_dl+0x1c17/0x2ba0 /kernel/sched/deadline.c:1441 This happens because the ->dl_boosted flag is currently not initialized by __dl_clear_params() (unlike the other flags) and setup_new_dl_entity() rightfully complains about it. Initialize dl_boosted to 0. Fixes: 2d3d891d3344 ("sched/deadline: Add SCHED_DEADLINE inheritance logic") Reported-by: syzbot+5ac8bac25f95e8b221e7@syzkaller.appspotmail.com Signed-off-by: Juri Lelli Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Tested-by: Daniel Wagner Link: https://lkml.kernel.org/r/20200617072919.818409-1-juri.lelli@redhat.com Signed-off-by: Sasha Levin --- kernel/sched/deadline.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index ebec37cb3be9a..8aecfb143859d 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2688,6 +2688,7 @@ void __dl_clear_params(struct task_struct *p) dl_se->dl_bw = 0; dl_se->dl_density = 0; + dl_se->dl_boosted = 0; dl_se->dl_throttled = 0; dl_se->dl_yielded = 0; dl_se->dl_non_contending = 0; -- 2.25.1