From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5177BC433E1 for ; Thu, 2 Jul 2020 01:23:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D80820885 for ; Thu, 2 Jul 2020 01:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593652986; bh=heI/zeiybxQ+XENOmCPW/BYUbzGnLzbbihRM/RDA930=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ku+qMiLLHRZFcTC23IUF+N1rm8dUkfyY0W0OYlQIwmzC/HQmjo268gsFr2VeA9rB7 hRn0TBdI48e7mAlZuUwM3FC5UsSI8zgsmFG2rhg3jQ/7m2UPq167RnZ+9B2TfMRQ5Z SL45CKVeLHfNgNKJ03RSD7kvtb7NWRLVcFighvPE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728180AbgGBBXF (ORCPT ); Wed, 1 Jul 2020 21:23:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:53302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbgGBBXB (ORCPT ); Wed, 1 Jul 2020 21:23:01 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E34F2082F; Thu, 2 Jul 2020 01:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593652981; bh=heI/zeiybxQ+XENOmCPW/BYUbzGnLzbbihRM/RDA930=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZPsF0tgWtzDXiAawBeHTa91mhDgp8Gw/FxF3gSBkxA0q5dgR07mBxACM65IBRQA03 fbnGHYKlkPERiwYN1OabEtrkfAfqTa3QFqzw63cHn0WwsEQygMtF+aBgHfRxSKl+0R qGSCLVZwg9zzA/58B41dA09MRxVYzWXRIWwoCibA= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tony Lindgren , maemo-leste@lists.dyne.org, Merlijn Wajer , Pavel Machek , Sebastian Reichel , Sasha Levin , devicetree@vger.kernel.org Subject: [PATCH AUTOSEL 5.7 05/53] ARM: dts: omap4-droid4: Fix spi configuration and increase rate Date: Wed, 1 Jul 2020 21:21:14 -0400 Message-Id: <20200702012202.2700645-5-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702012202.2700645-1-sashal@kernel.org> References: <20200702012202.2700645-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tony Lindgren [ Upstream commit 0df12a01f4857495816b05f048c4c31439446e35 ] We can currently sometimes get "RXS timed out" errors and "EOT timed out" errors with spi transfers. These errors can be made easy to reproduce by reading the cpcap iio values in a loop while keeping the CPUs busy by also reading /dev/urandom. The "RXS timed out" errors we can fix by adding spi-cpol and spi-cpha in addition to the spi-cs-high property we already have. The "EOT timed out" errors we can fix by increasing the spi clock rate to 9.6 MHz. Looks similar MC13783 PMIC says it works at spi clock rates up to 20 MHz, so let's assume we can pick any rate up to 20 MHz also for cpcap. Cc: maemo-leste@lists.dyne.org Cc: Merlijn Wajer Cc: Pavel Machek Cc: Sebastian Reichel Signed-off-by: Tony Lindgren Signed-off-by: Sasha Levin --- arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi index e39eee628afd6..08a7d3ce383f2 100644 --- a/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi +++ b/arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi @@ -13,8 +13,10 @@ cpcap: pmic@0 { #interrupt-cells = <2>; #address-cells = <1>; #size-cells = <0>; - spi-max-frequency = <3000000>; + spi-max-frequency = <9600000>; spi-cs-high; + spi-cpol; + spi-cpha; cpcap_adc: adc { compatible = "motorola,mapphone-cpcap-adc"; -- 2.25.1