From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009CAC433DF for ; Thu, 2 Jul 2020 01:34:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD9D820748 for ; Thu, 2 Jul 2020 01:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593653666; bh=bP4Svco64tcbNZ0VKLuxdblCqIX6tIwtPXqy85bho7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mzvuG7NjTKxDb5Gl0JKefuOVo6x6lxRbc/kNQVYGlH0t985FDN7Osk6HW/2UObNXS VjrwrQEFSvyglLRyo+DIfg1bv2qKg546AaVwTlybK+nQZLYIOdtipaLwImt1vCKk7N /4j6L+MmzOiWP3REQdhLNPJgC3cRISNRScnTq274= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728360AbgGBBe0 (ORCPT ); Wed, 1 Jul 2020 21:34:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:56482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728816AbgGBBZd (ORCPT ); Wed, 1 Jul 2020 21:25:33 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC2E220748; Thu, 2 Jul 2020 01:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593653133; bh=bP4Svco64tcbNZ0VKLuxdblCqIX6tIwtPXqy85bho7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZX+EHSL3CxRL4meXo5nLgSx+46MuW/fmNNNJRIrHTgTCJ17NwK9WZWaz4jSLtKz1b fwHUI+AxEWGAbef/3ur5oYStRj+QI9TwZ0xtfQ1iocwzSD+ybDcugy5CZ+vSE+vsig eXdFbBBVoEf2sCBb9/rKic3WwrzGWHS9Iqe7NXc8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Thierry Reding , Sowjanya Komatineni , Sasha Levin , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 07/40] gpu: host1x: Detach driver on unregister Date: Wed, 1 Jul 2020 21:23:28 -0400 Message-Id: <20200702012402.2701121-7-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702012402.2701121-1-sashal@kernel.org> References: <20200702012402.2701121-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Thierry Reding [ Upstream commit d9a0a05bf8c76e6dc79230669a8b5d685b168c30 ] Currently when a host1x device driver is unregistered, it is not detached from the host1x controller, which means that the device will stay around and when the driver is registered again, it may bind to the old, stale device rather than the new one that was created from scratch upon driver registration. This in turn can cause various weird crashes within the driver core because it is confronted with a device that was already deleted. Fix this by detaching the driver from the host1x controller when it is unregistered. This ensures that the deleted device also is no longer present in the device list that drivers will bind to. Reported-by: Sowjanya Komatineni Signed-off-by: Thierry Reding Tested-by: Sowjanya Komatineni Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/gpu/host1x/bus.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c index 742aa9ff21b87..fcda8621ae6f9 100644 --- a/drivers/gpu/host1x/bus.c +++ b/drivers/gpu/host1x/bus.c @@ -686,8 +686,17 @@ EXPORT_SYMBOL(host1x_driver_register_full); */ void host1x_driver_unregister(struct host1x_driver *driver) { + struct host1x *host1x; + driver_unregister(&driver->driver); + mutex_lock(&devices_lock); + + list_for_each_entry(host1x, &devices, list) + host1x_detach_driver(host1x, driver); + + mutex_unlock(&devices_lock); + mutex_lock(&drivers_lock); list_del_init(&driver->list); mutex_unlock(&drivers_lock); -- 2.25.1