[PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

[PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

[Lee Jones]

Kerneldoc syntax is used, but not complete.  Descriptions required.

Prevents warnings like:

 drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock'
 drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_unlock'

Cc: <stable@vger.kernel.org>
Cc: patches@opensource.cirrus.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/wm8350-core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
index 42b16503e6cd1..fbc77b218215c 100644
--- a/drivers/mfd/wm8350-core.c
+++ b/drivers/mfd/wm8350-core.c
@@ -131,6 +131,8 @@ EXPORT_SYMBOL_GPL(wm8350_block_write);
  * The WM8350 has a hardware lock which can be used to prevent writes to
  * some registers (generally those which can cause particularly serious
  * problems if misused).  This function enables that lock.
+ *
+ * @wm8350: pointer to local driver data structure
  */
 int wm8350_reg_lock(struct wm8350 *wm8350)
 {
@@ -160,6 +162,8 @@ EXPORT_SYMBOL_GPL(wm8350_reg_lock);
  * problems if misused).  This function disables that lock so updates
  * can be performed.  For maximum safety this should be done only when
  * required.
+ *
+ * @wm8350: pointer to local driver data structure
  */
 int wm8350_reg_unlock(struct wm8350 *wm8350)
 {
-- 
2.25.1

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

[Greg KH]

On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote:
> Kerneldoc syntax is used, but not complete.  Descriptions required.
> 
> Prevents warnings like:
> 
>  drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock'
>  drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_unlock'
> 
> Cc: <stable@vger.kernel.org>
> Cc: patches@opensource.cirrus.com
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/mfd/wm8350-core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> index 42b16503e6cd1..fbc77b218215c 100644
> --- a/drivers/mfd/wm8350-core.c
> +++ b/drivers/mfd/wm8350-core.c
> @@ -131,6 +131,8 @@ EXPORT_SYMBOL_GPL(wm8350_block_write);
>   * The WM8350 has a hardware lock which can be used to prevent writes to
>   * some registers (generally those which can cause particularly serious
>   * problems if misused).  This function enables that lock.
> + *
> + * @wm8350: pointer to local driver data structure
>   */
>  int wm8350_reg_lock(struct wm8350 *wm8350)
>  {
> @@ -160,6 +162,8 @@ EXPORT_SYMBOL_GPL(wm8350_reg_lock);
>   * problems if misused).  This function disables that lock so updates
>   * can be performed.  For maximum safety this should be done only when
>   * required.
> + *
> + * @wm8350: pointer to local driver data structure
>   */
>  int wm8350_reg_unlock(struct wm8350 *wm8350)
>  {
> -- 
> 2.25.1
> 

Why are all of these documentation fixes for stable?

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

[Lee Jones]

On Thu, 25 Jun 2020, Greg KH wrote:

> On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote:
> > Kerneldoc syntax is used, but not complete.  Descriptions required.
> > 
> > Prevents warnings like:
> > 
> >  drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock'
> >  drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_unlock'
> > 
> > Cc: <stable@vger.kernel.org>
> > Cc: patches@opensource.cirrus.com
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  drivers/mfd/wm8350-core.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> > index 42b16503e6cd1..fbc77b218215c 100644
> > --- a/drivers/mfd/wm8350-core.c
> > +++ b/drivers/mfd/wm8350-core.c
> > @@ -131,6 +131,8 @@ EXPORT_SYMBOL_GPL(wm8350_block_write);
> >   * The WM8350 has a hardware lock which can be used to prevent writes to
> >   * some registers (generally those which can cause particularly serious
> >   * problems if misused).  This function enables that lock.
> > + *
> > + * @wm8350: pointer to local driver data structure
> >   */
> >  int wm8350_reg_lock(struct wm8350 *wm8350)
> >  {
> > @@ -160,6 +162,8 @@ EXPORT_SYMBOL_GPL(wm8350_reg_lock);
> >   * problems if misused).  This function disables that lock so updates
> >   * can be performed.  For maximum safety this should be done only when
> >   * required.
> > + *
> > + * @wm8350: pointer to local driver data structure
> >   */
> >  int wm8350_reg_unlock(struct wm8350 *wm8350)
> >  {
> 
> Why are all of these documentation fixes for stable?

Because they fix compiler warnings.

Not correct?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

[Greg KH]

On Thu, Jun 25, 2020 at 08:13:13AM +0100, Lee Jones wrote:
> On Thu, 25 Jun 2020, Greg KH wrote:
> 
> > On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote:
> > > Kerneldoc syntax is used, but not complete.  Descriptions required.
> > > 
> > > Prevents warnings like:
> > > 
> > >  drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock'
> > >  drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_unlock'
> > > 
> > > Cc: <stable@vger.kernel.org>
> > > Cc: patches@opensource.cirrus.com
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >  drivers/mfd/wm8350-core.c | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> > > index 42b16503e6cd1..fbc77b218215c 100644
> > > --- a/drivers/mfd/wm8350-core.c
> > > +++ b/drivers/mfd/wm8350-core.c
> > > @@ -131,6 +131,8 @@ EXPORT_SYMBOL_GPL(wm8350_block_write);
> > >   * The WM8350 has a hardware lock which can be used to prevent writes to
> > >   * some registers (generally those which can cause particularly serious
> > >   * problems if misused).  This function enables that lock.
> > > + *
> > > + * @wm8350: pointer to local driver data structure
> > >   */
> > >  int wm8350_reg_lock(struct wm8350 *wm8350)
> > >  {
> > > @@ -160,6 +162,8 @@ EXPORT_SYMBOL_GPL(wm8350_reg_lock);
> > >   * problems if misused).  This function disables that lock so updates
> > >   * can be performed.  For maximum safety this should be done only when
> > >   * required.
> > > + *
> > > + * @wm8350: pointer to local driver data structure
> > >   */
> > >  int wm8350_reg_unlock(struct wm8350 *wm8350)
> > >  {
> > 
> > Why are all of these documentation fixes for stable?
> 
> Because they fix compiler warnings.

When you type 'make' these warnings show up?  We don't do documentation
builds as part of a normal build...

If for some reason we ever get rid of all of the thousands of current
warnings, then yes, I will be glad to consider stuff like this then.

thanks,

greg k-h

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

[Lee Jones]

On Thu, 25 Jun 2020, Greg KH wrote:

> On Thu, Jun 25, 2020 at 08:13:13AM +0100, Lee Jones wrote:
> > On Thu, 25 Jun 2020, Greg KH wrote:
> > 
> > > On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote:
> > > > Kerneldoc syntax is used, but not complete.  Descriptions required.
> > > > 
> > > > Prevents warnings like:
> > > > 
> > > >  drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock'
> > > >  drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_unlock'
> > > > 
> > > > Cc: <stable@vger.kernel.org>
> > > > Cc: patches@opensource.cirrus.com
> > > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > > ---
> > > >  drivers/mfd/wm8350-core.c | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > > 
> > > > diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
> > > > index 42b16503e6cd1..fbc77b218215c 100644
> > > > --- a/drivers/mfd/wm8350-core.c
> > > > +++ b/drivers/mfd/wm8350-core.c
> > > > @@ -131,6 +131,8 @@ EXPORT_SYMBOL_GPL(wm8350_block_write);
> > > >   * The WM8350 has a hardware lock which can be used to prevent writes to
> > > >   * some registers (generally those which can cause particularly serious
> > > >   * problems if misused).  This function enables that lock.
> > > > + *
> > > > + * @wm8350: pointer to local driver data structure
> > > >   */
> > > >  int wm8350_reg_lock(struct wm8350 *wm8350)
> > > >  {
> > > > @@ -160,6 +162,8 @@ EXPORT_SYMBOL_GPL(wm8350_reg_lock);
> > > >   * problems if misused).  This function disables that lock so updates
> > > >   * can be performed.  For maximum safety this should be done only when
> > > >   * required.
> > > > + *
> > > > + * @wm8350: pointer to local driver data structure
> > > >   */
> > > >  int wm8350_reg_unlock(struct wm8350 *wm8350)
> > > >  {
> > > 
> > > Why are all of these documentation fixes for stable?
> > 
> > Because they fix compiler warnings.
> 
> When you type 'make' these warnings show up?  We don't do documentation
> builds as part of a normal build...

'make W=1' yes. :)

> If for some reason we ever get rid of all of the thousands of current
> warnings, then yes, I will be glad to consider stuff like this then.

Workin' on it!

Sorry for the noise (for now).

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

[Jonathan Corbet]

On Thu, 25 Jun 2020 08:13:13 +0100
Lee Jones <lee.jones@linaro.org> wrote:

> > Why are all of these documentation fixes for stable?  
> 
> Because they fix compiler warnings.
> 
> Not correct?

I am overjoyed to see people fixing docs build warnings, it is work that
is desperately needed.  That said, these warning fixes are probably not
stable material; the problem is bigger and longer-term than that.

Thanks,

jon

Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args

[Lee Jones]

On Thu, 25 Jun 2020, Jonathan Corbet wrote:
> On Thu, 25 Jun 2020 08:13:13 +0100
> Lee Jones <lee.jones@linaro.org> wrote:
> 
> > > Why are all of these documentation fixes for stable?  
> > 
> > Because they fix compiler warnings.
> > 
> > Not correct?
> 
> I am overjoyed to see people fixing docs build warnings, it is work that
> is desperately needed.

I'll do what I can with the time that I have.

The plan is to keep plodding on and seeing how far I can take it.  A
clean W=1 build sounds like rainbows and unicorns presently, but Rome
wasn't built in a day.

Tell you the truth, drafting patches (again, after a break) is a
welcome change/release from digging around and reviewing Android
Stable patches.  It's the only thing keeping me sane. :)

> That said, these warning fixes are probably not
> stable material; the problem is bigger and longer-term than that.

Fair enough.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH 02/10] mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices()

[Lee Jones]

Each function parameter should be documented in kerneldoc format.

Squashes the following W=1 warnings:

 drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'dev' not described in 'devm_mfd_add_devices'
 drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'id' not described in 'devm_mfd_add_devices'
 drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'cells' not described in 'devm_mfd_add_devices'
 drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'n_devs' not described in 'devm_mfd_add_devices'
 drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'mem_base' not described in 'devm_mfd_add_devices'
 drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'irq_base' not described in 'devm_mfd_add_devices'
 drivers/mfd/mfd-core.c:326: warning: Function parameter or member 'domain' not described in 'devm_mfd_add_devices'

Cc: <stable@vger.kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/mfd-core.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index f5a73af60dd40..720e5c8b1588c 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -318,6 +318,16 @@ static void devm_mfd_dev_release(struct device *dev, void *res)
  * Returns 0 on success or an appropriate negative error number on failure.
  * All child-devices of the MFD will automatically be removed when it gets
  * unbinded.
+ *
+ * @dev:	Pointer to parent device.
+ * @id:		Can be PLATFORM_DEVID_AUTO to let the Platform API take care
+ *		of device numbering, or will be added to a device's cell_id.
+ * @cells:	Array of (struct mfd_cell)s describing child devices.
+ * @n_devs:	Number of child devices to register.
+ * @mem_base:	Parent register range resource for child devices.
+ * @irq_base:	Base of the range of virtual interrupt numbers allocated for
+ *		this MFD device. Unused if @domain is specified.
+ * @domain:	Interrupt domain to create mappings for hardware interrupts.
  */
 int devm_mfd_add_devices(struct device *dev, int id,
 			 const struct mfd_cell *cells, int n_devs,
-- 
2.25.1

Re: [PATCH 02/10] mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices()

[Sasha Levin]

Hi

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.

v5.7.6: Build OK!
v5.4.49: Build OK!
v4.19.130: Build OK!
v4.14.186: Build OK!
v4.9.228: Build OK!
v4.4.228: Failed to apply! Possible dependencies:
    a8f447be8056d ("mfd: Add resource managed APIs for mfd_add_devices")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha

Re: [PATCH 02/10] mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices()

[Lee Jones]

On Wed, 01 Jul 2020, Sasha Levin wrote:

> Hi
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
> 
> The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.
> 
> v5.7.6: Build OK!
> v5.4.49: Build OK!
> v4.19.130: Build OK!
> v4.14.186: Build OK!
> v4.9.228: Build OK!
> v4.4.228: Failed to apply! Possible dependencies:
>     a8f447be8056d ("mfd: Add resource managed APIs for mfd_add_devices")
> 
> 
> NOTE: The patch will not be queued to stable trees until it is upstream.
> 
> How should we proceed with this patch?

Please drop it.

Greg indicated that these should not be bound for Stable.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 02/10] mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices()

[Sasha Levin]

Hi

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.

v5.7.6: Build OK!
v5.4.49: Build OK!
v4.19.130: Build OK!
v4.14.186: Build OK!
v4.9.228: Build OK!
v4.4.228: Failed to apply! Possible dependencies:
    a8f447be8056d ("mfd: Add resource managed APIs for mfd_add_devices")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha

[PATCH 03/10] mfd: db8500-prcmu: Add description for 'reset_reason' in kerneldoc

[Lee Jones]

Each function parameter should be documented in kerneldoc format.

Squashes the following W=1 warnings:

 drivers/mfd/db8500-prcmu.c:2281: warning: Function parameter or member 'reset_code' not described in 'db8500_prcmu_system_reset'
 drivers/mfd/db8500-prcmu.c:3012: warning: Function parameter or member 'pdev' not described in 'db8500_prcmu_probe'

Cc: <stable@vger.kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/db8500-prcmu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 0452b43b04232..9b58b02967638 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -2276,6 +2276,8 @@ bool db8500_prcmu_is_ac_wake_requested(void)
  *
  * Saves the reset reason code and then sets the APE_SOFTRST register which
  * fires interrupt to fw
+ *
+ * @reset_code: The reason for system reset
  */
 void db8500_prcmu_system_reset(u16 reset_code)
 {
-- 
2.25.1

Re: [PATCH 03/10] mfd: db8500-prcmu: Add description for 'reset_reason' in kerneldoc

[Linus Walleij]

On Thu, Jun 25, 2020 at 8:46 AM Lee Jones <lee.jones@linaro.org> wrote:

> Each function parameter should be documented in kerneldoc format.
>
> Squashes the following W=1 warnings:
>
>  drivers/mfd/db8500-prcmu.c:2281: warning: Function parameter or member 'reset_code' not described in 'db8500_prcmu_system_reset'
>  drivers/mfd/db8500-prcmu.c:3012: warning: Function parameter or member 'pdev' not described in 'db8500_prcmu_probe'
>
> Cc: <stable@vger.kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

[PATCH 04/10] mfd: db8500-prcmu: Remove incorrect function header from .probe() function

[Lee Jones]

Not only is the current header incorrect, the isn't actually a
need to document the ubiquitous platform probe call.

Cc: <stable@vger.kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/db8500-prcmu.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 9b58b02967638..a9d9c1cdf546b 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -3006,10 +3006,6 @@ static int db8500_prcmu_register_ab8500(struct device *parent)
 	return mfd_add_devices(parent, 0, ab850x_cell, 1, NULL, 0, NULL);
 }
 
-/**
- * prcmu_fw_init - arch init call for the Linux PRCMU fw init logic
- *
- */
 static int db8500_prcmu_probe(struct platform_device *pdev)
 {
 	struct device_node *np = pdev->dev.of_node;
-- 
2.25.1

Re: [PATCH 04/10] mfd: db8500-prcmu: Remove incorrect function header from .probe() function

[Linus Walleij]

On Thu, Jun 25, 2020 at 8:46 AM Lee Jones <lee.jones@linaro.org> wrote:

> Not only is the current header incorrect, the isn't actually a
> need to document the ubiquitous platform probe call.
>
> Cc: <stable@vger.kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

[PATCH 05/10] mfd: omap-usb-host: Remove invalid use of kerneldoc syntax

[Lee Jones]

Kerneldoc is for documenting function arguments and return values.

Prevents warnings like:

 drivers/mfd/omap-usb-host.c:128: warning: cannot understand function prototype: 'const char * const port_modes[] = '

Cc: <stable@vger.kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: Roger Quadros <rogerq@ti.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/omap-usb-host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 1f4f01b02d98c..f56cdf3149dc0 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -120,7 +120,7 @@ static inline u32 usbhs_read(void __iomem *base, u32 reg)
 
 /*-------------------------------------------------------------------------*/
 
-/**
+/*
  * Map 'enum usbhs_omap_port_mode' found in <linux/platform_data/usb-omap.h>
  * to the device tree binding portN-mode found in
  * 'Documentation/devicetree/bindings/mfd/omap-usb-host.txt'
-- 
2.25.1

[PATCH 06/10] mfd: omap-usb-host: Provide description for 'pdev' argument to .probe()

[Lee Jones]

Kerneldoc syntax is used, but not complete.  Arg descriptions required.

Prevents warnings like:

 drivers/mfd/omap-usb-host.c:531: warning: Function parameter or member 'pdev' not described in 'usbhs_omap_probe'

Cc: <stable@vger.kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: Roger Quadros <rogerq@ti.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/omap-usb-host.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index f56cdf3149dc0..aca5a160c1b24 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -526,6 +526,8 @@ static const struct of_device_id usbhs_child_match_table[] = {
  * usbhs_omap_probe - initialize TI-based HCDs
  *
  * Allocates basic resources for this USB host controller.
+ *
+ * @pdev: Pointer to this device's platform device structure
  */
 static int usbhs_omap_probe(struct platform_device *pdev)
 {
-- 
2.25.1

[PATCH 07/10] mfd: omap-usb-tll: Provide description for 'pdev' argument to .probe()

[Lee Jones]

Kerneldoc syntax is used, but not complete.  Arg descriptions required.

Prevents warnings like:

 drivers/mfd/omap-usb-tll.c:204: warning: Function parameter or member 'pdev' not described in 'usbtll_omap_probe

Cc: <stable@vger.kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: Roger Quadros <rogerq@ti.com>
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/omap-usb-tll.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index 4b7f73c317e87..04a444007cf4e 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -199,6 +199,8 @@ static unsigned ohci_omap3_fslsmode(enum usbhs_omap_port_mode mode)
  * usbtll_omap_probe - initialize TI-based HCDs
  *
  * Allocates basic resources for this USB host controller.
+ *
+ * @pdev: Pointer to this device's platform device structure
  */
 static int usbtll_omap_probe(struct platform_device *pdev)
 {
-- 
2.25.1

[PATCH 08/10] mfd: atmel-smc: Silence comparison of unsigned expression < 0 is always false warning (W=1)

[Lee Jones]

GENMASK and it's callees conduct checking to ensure the passed
parameters are valid.  One of those checks is for '< 0'.  So if an
unsigned value is passed, in an invalid comparison takes place.

Judging from the current code, it looks as though 'unsigned int'
is the correct type to use, so simply cast these small values
with no chance of being false negative to signed int for
comparison/error checking purposes.

Squashes the following W=1 warnings:

 In file included from /home/lee/projects/linux/kernel/include/linux/bits.h:23,
 from /home/lee/projects/linux/kernel/include/linux/bitops.h:5,
 from /home/lee/projects/linux/kernel/include/linux/kernel.h:12,
 from /home/lee/projects/linux/kernel/include/linux/mfd/syscon/atmel-smc.h:14,
 from /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c:11:
 /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c: In function ‘atmel_smc_cs_encode_ncycles’:
 /home/lee/projects/linux/kernel/include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
 26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
 | ^
 /home/lee/projects/linux/kernel/include/linux/build_bug.h:16:62: note: in definition of macro ‘BUILD_BUG_ON_ZERO’
 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
 | ^
 /home/lee/projects/linux/kernel/include/linux/bits.h:39:3: note: in expansion of macro ‘GENMASK_INPUT_CHECK’
 39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
 | ^~~~~~~~~~~~~~~~~~~
 /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c:49:25: note: in expansion of macro ‘GENMASK’
 49 | unsigned int lsbmask = GENMASK(msbpos - 1, 0);
 | ^~~~~~~
 /home/lee/projects/linux/kernel/include/linux/bits.h:26:40: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
 26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
 | ^
 /home/lee/projects/linux/kernel/include/linux/build_bug.h:16:62: note: in definition of macro ‘BUILD_BUG_ON_ZERO’
 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
 | ^
 /home/lee/projects/linux/kernel/include/linux/bits.h:39:3: note: in expansion of macro ‘GENMASK_INPUT_CHECK’
 39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
 | ^~~~~~~~~~~~~~~~~~~

Cc: <stable@vger.kernel.org>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/atmel-smc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c
index 1fa2ec950e7df..17bbe9d1fa740 100644
--- a/drivers/mfd/atmel-smc.c
+++ b/drivers/mfd/atmel-smc.c
@@ -46,8 +46,8 @@ static int atmel_smc_cs_encode_ncycles(unsigned int ncycles,
 				       unsigned int msbfactor,
 				       unsigned int *encodedval)
 {
-	unsigned int lsbmask = GENMASK(msbpos - 1, 0);
-	unsigned int msbmask = GENMASK(msbwidth - 1, 0);
+	unsigned int lsbmask = GENMASK((int)msbpos - 1, 0);
+	unsigned int msbmask = GENMASK((int)msbwidth - 1, 0);
 	unsigned int msb, lsb;
 	int ret = 0;
 
-- 
2.25.1

Re: [PATCH 08/10] mfd: atmel-smc: Silence comparison of unsigned expression < 0 is always false warning (W=1)

[Alexandre Belloni]

Hi,

On 25/06/2020 07:46:17+0100, Lee Jones wrote:
> GENMASK and it's callees conduct checking to ensure the passed
> parameters are valid.  One of those checks is for '< 0'.  So if an
> unsigned value is passed, in an invalid comparison takes place.
> 
> Judging from the current code, it looks as though 'unsigned int'
> is the correct type to use, so simply cast these small values
> with no chance of being false negative to signed int for
> comparison/error checking purposes.
> 

I've been thinking about that one but shouldn't the proper fix be in
GENMASK? My understanding is that this happens because l is 0 and I
don't think GENMASK would ever expect negative number. What about simply
checking that h != l when l is 0?

> Squashes the following W=1 warnings:
> 
>  In file included from /home/lee/projects/linux/kernel/include/linux/bits.h:23,
>  from /home/lee/projects/linux/kernel/include/linux/bitops.h:5,
>  from /home/lee/projects/linux/kernel/include/linux/kernel.h:12,
>  from /home/lee/projects/linux/kernel/include/linux/mfd/syscon/atmel-smc.h:14,
>  from /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c:11:
>  /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c: In function ‘atmel_smc_cs_encode_ncycles’:
>  /home/lee/projects/linux/kernel/include/linux/bits.h:26:28: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>  26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
>  | ^
>  /home/lee/projects/linux/kernel/include/linux/build_bug.h:16:62: note: in definition of macro ‘BUILD_BUG_ON_ZERO’
>  16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
>  | ^
>  /home/lee/projects/linux/kernel/include/linux/bits.h:39:3: note: in expansion of macro ‘GENMASK_INPUT_CHECK’
>  39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
>  | ^~~~~~~~~~~~~~~~~~~
>  /home/lee/projects/linux/kernel/drivers/mfd/atmel-smc.c:49:25: note: in expansion of macro ‘GENMASK’
>  49 | unsigned int lsbmask = GENMASK(msbpos - 1, 0);
>  | ^~~~~~~
>  /home/lee/projects/linux/kernel/include/linux/bits.h:26:40: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>  26 | __builtin_constant_p((l) > (h)), (l) > (h), 0)))
>  | ^
>  /home/lee/projects/linux/kernel/include/linux/build_bug.h:16:62: note: in definition of macro ‘BUILD_BUG_ON_ZERO’
>  16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
>  | ^
>  /home/lee/projects/linux/kernel/include/linux/bits.h:39:3: note: in expansion of macro ‘GENMASK_INPUT_CHECK’
>  39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
>  | ^~~~~~~~~~~~~~~~~~~
> 
> Cc: <stable@vger.kernel.org>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/mfd/atmel-smc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c
> index 1fa2ec950e7df..17bbe9d1fa740 100644
> --- a/drivers/mfd/atmel-smc.c
> +++ b/drivers/mfd/atmel-smc.c
> @@ -46,8 +46,8 @@ static int atmel_smc_cs_encode_ncycles(unsigned int ncycles,
>  				       unsigned int msbfactor,
>  				       unsigned int *encodedval)
>  {
> -	unsigned int lsbmask = GENMASK(msbpos - 1, 0);
> -	unsigned int msbmask = GENMASK(msbwidth - 1, 0);
> +	unsigned int lsbmask = GENMASK((int)msbpos - 1, 0);
> +	unsigned int msbmask = GENMASK((int)msbwidth - 1, 0);
>  	unsigned int msb, lsb;
>  	int ret = 0;
>  
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 08/10] mfd: atmel-smc: Silence comparison of unsigned expression < 0 is always false warning (W=1)

[Lee Jones]

On Fri, 26 Jun 2020, Alexandre Belloni wrote:

> Hi,
> 
> On 25/06/2020 07:46:17+0100, Lee Jones wrote:
> > GENMASK and it's callees conduct checking to ensure the passed
> > parameters are valid.  One of those checks is for '< 0'.  So if an
> > unsigned value is passed, in an invalid comparison takes place.
> > 
> > Judging from the current code, it looks as though 'unsigned int'
> > is the correct type to use, so simply cast these small values
> > with no chance of being false negative to signed int for
> > comparison/error checking purposes.
> > 
> 
> I've been thinking about that one but shouldn't the proper fix be in
> GENMASK? My understanding is that this happens because l is 0 and I
> don't think GENMASK would ever expect negative number. What about simply
> checking that h != l when l is 0?

Looks like Rikard Falkeborn recently submitted a patch to 'fix' this
issue.  However, Linus slammed it, decrying that it's the warning
that's wrong, not the code.  Looks like the type-limits warning might
be getting downgraded to W=2 instead (although I don't see a patch
yet).

I'm going to drop this patch.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments

[Lee Jones]

Kerneldoc valication gets confused if syntax isn't "@.*: ".

Adding the missing colons squashes the following W=1 warnings:

drivers/mfd/atmel-smc.c:247: warning: Function parameter or member 'conf' not described in 'atmel_smc_cs_conf_apply'
drivers/mfd/atmel-smc.c:268: warning: Function parameter or member 'conf' not described in 'atmel_hsmc_cs_conf_apply'

Cc: <stable@vger.kernel.org>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/atmel-smc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c
index 17bbe9d1fa740..4aac96d213369 100644
--- a/drivers/mfd/atmel-smc.c
+++ b/drivers/mfd/atmel-smc.c
@@ -237,7 +237,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_cycle);
  * atmel_smc_cs_conf_apply - apply an SMC CS conf
  * @regmap: the SMC regmap
  * @cs: the CS id
- * @conf the SMC CS conf to apply
+ * @conf: the SMC CS conf to apply
  *
  * Applies an SMC CS configuration.
  * Only valid on at91sam9/avr32 SoCs.
@@ -257,7 +257,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_apply);
  * @regmap: the HSMC regmap
  * @cs: the CS id
  * @layout: the layout of registers
- * @conf the SMC CS conf to apply
+ * @conf: the SMC CS conf to apply
  *
  * Applies an SMC CS configuration.
  * Only valid on post-sama5 SoCs.
-- 
2.25.1

Re: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments

[Greg KH]

On Thu, Jun 25, 2020 at 07:46:18AM +0100, Lee Jones wrote:
> Kerneldoc valication gets confused if syntax isn't "@.*: ".
> 
> Adding the missing colons squashes the following W=1 warnings:
> 
> drivers/mfd/atmel-smc.c:247: warning: Function parameter or member 'conf' not described in 'atmel_smc_cs_conf_apply'
> drivers/mfd/atmel-smc.c:268: warning: Function parameter or member 'conf' not described in 'atmel_hsmc_cs_conf_apply'

Why is this a stable patch?

Re: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments

[Alexandre Belloni]

On 25/06/2020 07:46:18+0100, Lee Jones wrote:
> Kerneldoc valication gets confused if syntax isn't "@.*: ".
> 
> Adding the missing colons squashes the following W=1 warnings:
> 
> drivers/mfd/atmel-smc.c:247: warning: Function parameter or member 'conf' not described in 'atmel_smc_cs_conf_apply'
> drivers/mfd/atmel-smc.c:268: warning: Function parameter or member 'conf' not described in 'atmel_hsmc_cs_conf_apply'
> 
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> Cc: <stable@vger.kernel.org>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/mfd/atmel-smc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c
> index 17bbe9d1fa740..4aac96d213369 100644
> --- a/drivers/mfd/atmel-smc.c
> +++ b/drivers/mfd/atmel-smc.c
> @@ -237,7 +237,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_cycle);
>   * atmel_smc_cs_conf_apply - apply an SMC CS conf
>   * @regmap: the SMC regmap
>   * @cs: the CS id
> - * @conf the SMC CS conf to apply
> + * @conf: the SMC CS conf to apply
>   *
>   * Applies an SMC CS configuration.
>   * Only valid on at91sam9/avr32 SoCs.
> @@ -257,7 +257,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_apply);
>   * @regmap: the HSMC regmap
>   * @cs: the CS id
>   * @layout: the layout of registers
> - * @conf the SMC CS conf to apply
> + * @conf: the SMC CS conf to apply
>   *
>   * Applies an SMC CS configuration.
>   * Only valid on post-sama5 SoCs.
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments

[Sasha Levin]

Hi

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.

v5.7.6: Build OK!
v5.4.49: Build OK!
v4.19.130: Build OK!
v4.14.186: Build OK!
v4.9.228: Failed to apply! Possible dependencies:
    87108dc78eb89 ("memory: atmel-ebi: Enable the SMC clock if specified")
    8eb8c7d844b9d ("memory: atmel-ebi: Simplify SMC config code")
    b0f3ab20e7649 ("mfd: syscon: atmel-smc: Add helper to retrieve register layout")
    b5169d35ed585 ("mtd: nand: atmel: return error code of nand_scan_ident/tail() on error")
    f88fc122cc34c ("mtd: nand: Cleanup/rework the atmel_nand driver")
    f9ce2eddf1769 ("mtd: nand: atmel: Add ->setup_data_interface() hooks")
    fe9d7cb22ef3a ("mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation")

v4.4.228: Failed to apply! Possible dependencies:
    1d8d8b5c852b6 ("mtd: nand: fix drivers abusing mtd->priv")
    4bd4ebcc540c3 ("mtd: nand: make use of mtd_to_nand() in NAND drivers")
    5575075612cad ("mtd: atmel_nand: Support PMECC on SAMA5D2")
    5ddc7bd43ccc7 ("mtd: atmel_nand: Support variable RB_EDGE interrupts")
    66e8e47eae658 ("mtd: pxa3xx_nand: Fix initial controller configuration")
    6a4ec4cd08888 ("memory: add Atmel EBI (External Bus Interface) driver")
    72eaec21b0cf1 ("mtd: nand: atmel_nand: constify atmel_nand_caps structures")
    87108dc78eb89 ("memory: atmel-ebi: Enable the SMC clock if specified")
    8eb8c7d844b9d ("memory: atmel-ebi: Simplify SMC config code")
    b0f3ab20e7649 ("mfd: syscon: atmel-smc: Add helper to retrieve register layout")
    c7f00c29aa846 ("mtd: pxa3xx_nand: Increase the initial chunk size")
    cc00383722db7 ("mtd: nand: atmel: switch to mtd_ooblayout_ops")
    d699ed250c073 ("mtd: nand: make use of nand_set/get_controller_data() helpers")
    ee194289502a6 ("memory/atmel-ebi: Fix ns <-> cycles conversions")
    ee4fec5f44a2c ("memory: atmel-ebi: use PTR_ERR_OR_ZERO() to simplify the code")
    f88fc122cc34c ("mtd: nand: Cleanup/rework the atmel_nand driver")
    fe9d7cb22ef3a ("mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha

Re: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments

[Lee Jones]

On Wed, 01 Jul 2020, Sasha Levin wrote:

> Hi
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
> 
> The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.
> 
> v5.7.6: Build OK!
> v5.4.49: Build OK!
> v4.19.130: Build OK!
> v4.14.186: Build OK!
> v4.9.228: Failed to apply! Possible dependencies:
>     87108dc78eb89 ("memory: atmel-ebi: Enable the SMC clock if specified")
>     8eb8c7d844b9d ("memory: atmel-ebi: Simplify SMC config code")
>     b0f3ab20e7649 ("mfd: syscon: atmel-smc: Add helper to retrieve register layout")
>     b5169d35ed585 ("mtd: nand: atmel: return error code of nand_scan_ident/tail() on error")
>     f88fc122cc34c ("mtd: nand: Cleanup/rework the atmel_nand driver")
>     f9ce2eddf1769 ("mtd: nand: atmel: Add ->setup_data_interface() hooks")
>     fe9d7cb22ef3a ("mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation")
> 
> v4.4.228: Failed to apply! Possible dependencies:
>     1d8d8b5c852b6 ("mtd: nand: fix drivers abusing mtd->priv")
>     4bd4ebcc540c3 ("mtd: nand: make use of mtd_to_nand() in NAND drivers")
>     5575075612cad ("mtd: atmel_nand: Support PMECC on SAMA5D2")
>     5ddc7bd43ccc7 ("mtd: atmel_nand: Support variable RB_EDGE interrupts")
>     66e8e47eae658 ("mtd: pxa3xx_nand: Fix initial controller configuration")
>     6a4ec4cd08888 ("memory: add Atmel EBI (External Bus Interface) driver")
>     72eaec21b0cf1 ("mtd: nand: atmel_nand: constify atmel_nand_caps structures")
>     87108dc78eb89 ("memory: atmel-ebi: Enable the SMC clock if specified")
>     8eb8c7d844b9d ("memory: atmel-ebi: Simplify SMC config code")
>     b0f3ab20e7649 ("mfd: syscon: atmel-smc: Add helper to retrieve register layout")
>     c7f00c29aa846 ("mtd: pxa3xx_nand: Increase the initial chunk size")
>     cc00383722db7 ("mtd: nand: atmel: switch to mtd_ooblayout_ops")
>     d699ed250c073 ("mtd: nand: make use of nand_set/get_controller_data() helpers")
>     ee194289502a6 ("memory/atmel-ebi: Fix ns <-> cycles conversions")
>     ee4fec5f44a2c ("memory: atmel-ebi: use PTR_ERR_OR_ZERO() to simplify the code")
>     f88fc122cc34c ("mtd: nand: Cleanup/rework the atmel_nand driver")
>     fe9d7cb22ef3a ("mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation")
> 
> 
> NOTE: The patch will not be queued to stable trees until it is upstream.
> 
> How should we proceed with this patch?

Please drop it.

Greg indicated that these should not be bound for Stable.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments

[Sasha Levin]

Hi

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.

v5.7.6: Build OK!
v5.4.49: Build OK!
v4.19.130: Build OK!
v4.14.186: Build OK!
v4.9.228: Failed to apply! Possible dependencies:
    87108dc78eb89 ("memory: atmel-ebi: Enable the SMC clock if specified")
    8eb8c7d844b9d ("memory: atmel-ebi: Simplify SMC config code")
    b0f3ab20e7649 ("mfd: syscon: atmel-smc: Add helper to retrieve register layout")
    b5169d35ed585 ("mtd: nand: atmel: return error code of nand_scan_ident/tail() on error")
    f88fc122cc34c ("mtd: nand: Cleanup/rework the atmel_nand driver")
    f9ce2eddf1769 ("mtd: nand: atmel: Add ->setup_data_interface() hooks")
    fe9d7cb22ef3a ("mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation")

v4.4.228: Failed to apply! Possible dependencies:
    1d8d8b5c852b6 ("mtd: nand: fix drivers abusing mtd->priv")
    4bd4ebcc540c3 ("mtd: nand: make use of mtd_to_nand() in NAND drivers")
    5575075612cad ("mtd: atmel_nand: Support PMECC on SAMA5D2")
    5ddc7bd43ccc7 ("mtd: atmel_nand: Support variable RB_EDGE interrupts")
    66e8e47eae658 ("mtd: pxa3xx_nand: Fix initial controller configuration")
    6a4ec4cd08888 ("memory: add Atmel EBI (External Bus Interface) driver")
    72eaec21b0cf1 ("mtd: nand: atmel_nand: constify atmel_nand_caps structures")
    87108dc78eb89 ("memory: atmel-ebi: Enable the SMC clock if specified")
    8eb8c7d844b9d ("memory: atmel-ebi: Simplify SMC config code")
    b0f3ab20e7649 ("mfd: syscon: atmel-smc: Add helper to retrieve register layout")
    c7f00c29aa846 ("mtd: pxa3xx_nand: Increase the initial chunk size")
    cc00383722db7 ("mtd: nand: atmel: switch to mtd_ooblayout_ops")
    d699ed250c073 ("mtd: nand: make use of nand_set/get_controller_data() helpers")
    ee194289502a6 ("memory/atmel-ebi: Fix ns <-> cycles conversions")
    ee4fec5f44a2c ("memory: atmel-ebi: use PTR_ERR_OR_ZERO() to simplify the code")
    f88fc122cc34c ("mtd: nand: Cleanup/rework the atmel_nand driver")
    fe9d7cb22ef3a ("mfd: syscon: atmel-smc: Add new helpers to ease SMC regs manipulation")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha

[PATCH 10/10] mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args

[Lee Jones]

Kerneldoc syntax is used, but not complete.  Arg descriptions are required.

Fixes the following W=1 build warnings:

 drivers/mfd/altera-sysmgr.c:95: warning: Function parameter or member 'np' not described in 'altr_sysmgr_regmap_lookup_by_phandle'
 drivers/mfd/altera-sysmgr.c:95: warning: Function parameter or member 'property' not described in 'altr_sysmgr_regmap_lookup_by_phandle'

Cc: <stable@vger.kernel.org>
Cc: Thor Thayer <thor.thayer@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/altera-sysmgr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c
index 83f0765f819b0..41076d121dd54 100644
--- a/drivers/mfd/altera-sysmgr.c
+++ b/drivers/mfd/altera-sysmgr.c
@@ -89,6 +89,9 @@ static struct regmap_config altr_sysmgr_regmap_cfg = {
  * altr_sysmgr_regmap_lookup_by_phandle
  * Find the sysmgr previous configured in probe() and return regmap property.
  * Return: regmap if found or error if not found.
+ *
+ * @np: Pointer to device's Device Tree node
+ * @property: Device Tree property name which references the sysmgr
  */
 struct regmap *altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np,
 						    const char *property)
-- 
2.25.1

Re: [PATCH 10/10] mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args

[Sasha Levin]

Hi

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.

v5.7.6: Build OK!
v5.4.49: Build OK!
v4.19.130: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.14.186: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.9.228: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")
    d0f949e220fdf ("mfd: Add STM32 Timers driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.4.228: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    8ce064bfe7c8c ("MAINTAINERS: Add Altera Arria10 System Resource Chip")
    937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")
    9787f5e28b507 ("mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip")
    b25c6b7d2801f ("mfd: act8945a: Add Active-semi ACT8945A PMIC MFD driver")
    d0f949e220fdf ("mfd: Add STM32 Timers driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha

Re: [PATCH 10/10] mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args

[Lee Jones]

On Wed, 01 Jul 2020, Sasha Levin wrote:

> Hi
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
> 
> The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.
> 
> v5.7.6: Build OK!
> v5.4.49: Build OK!
> v4.19.130: Failed to apply! Possible dependencies:
>     51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
>     f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")
> 
> v4.14.186: Failed to apply! Possible dependencies:
>     51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
>     f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")
> 
> v4.9.228: Failed to apply! Possible dependencies:
>     51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
>     937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")
>     d0f949e220fdf ("mfd: Add STM32 Timers driver")
>     f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")
> 
> v4.4.228: Failed to apply! Possible dependencies:
>     51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
>     8ce064bfe7c8c ("MAINTAINERS: Add Altera Arria10 System Resource Chip")
>     937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")
>     9787f5e28b507 ("mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip")
>     b25c6b7d2801f ("mfd: act8945a: Add Active-semi ACT8945A PMIC MFD driver")
>     d0f949e220fdf ("mfd: Add STM32 Timers driver")
>     f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")
> 
> 
> NOTE: The patch will not be queued to stable trees until it is upstream.
> 
> How should we proceed with this patch?

Please drop it.

Greg indicated that these should not be bound for Stable.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 10/10] mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args

[Sasha Levin]

Hi

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.7.6, v5.4.49, v4.19.130, v4.14.186, v4.9.228, v4.4.228.

v5.7.6: Build OK!
v5.4.49: Build OK!
v4.19.130: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.14.186: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.9.228: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")
    d0f949e220fdf ("mfd: Add STM32 Timers driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")

v4.4.228: Failed to apply! Possible dependencies:
    51908d2e9b7c7 ("mfd: stpmic1: Add STPMIC1 driver")
    8ce064bfe7c8c ("MAINTAINERS: Add Altera Arria10 System Resource Chip")
    937d3a0af521e ("mfd: Add support for Allwinner SoCs ADC")
    9787f5e28b507 ("mfd: altr_a10sr: Add Altera Arria10 DevKit System Resource Chip")
    b25c6b7d2801f ("mfd: act8945a: Add Active-semi ACT8945A PMIC MFD driver")
    d0f949e220fdf ("mfd: Add STM32 Timers driver")
    f36e789a1f8d0 ("mfd: altera-sysmgr: Add SOCFPGA System Manager")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha