stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: stable@vger.kernel.org, sashal@kernel.org
Subject: Re: [PATCH 4.19] IB/umem: fix reference count leak in ib_umem_odp_get()
Date: Mon, 13 Jul 2020 16:52:26 +0200	[thread overview]
Message-ID: <20200713145226.GA3767483@kroah.com> (raw)
In-Reply-To: <20200619160307.1601016-1-yangyingliang@huawei.com>

On Fri, Jun 19, 2020 at 04:03:07PM +0000, Yang Yingliang wrote:
> Add missing mmput() on error path to avoid ref-count leak.
> 
> This problem has already been resolved in mainline by
> f27a0d50a4bc ("RDMA/umem: Use umem->owning_mm inside ODP").
> 
> Fixes: 79bb5b7ee177 ("RDMA/umem: Fix missing mmap_sem in get umem ODP call")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/infiniband/core/umem_odp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

We need an ack by the owner/maintainer of this code, please get the IB
developers/maintainers to do that first.

Any reason why you didn't cc: them also?

thanks,

greg k-h

  reply	other threads:[~2020-07-13 14:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 16:03 [PATCH 4.19] IB/umem: fix reference count leak in ib_umem_odp_get() Yang Yingliang
2020-07-13 14:52 ` Greg KH [this message]
2020-07-14  2:55   ` Yang Yingliang
  -- strict thread matches above, loose matches on Subject: below --
2020-07-14 10:57 Yang Yingliang
2020-07-14  6:08 ` Greg KH
2020-07-14  6:45   ` Yang Yingliang
2020-07-14 11:28 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200713145226.GA3767483@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).