From: Greg KH <gregkh@linuxfoundation.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: stable@vger.kernel.org, sashal@kernel.org, dledford@redhat.com,
jgg@ziepe.ca
Subject: Re: [PATCH 4.19] IB/umem: fix reference count leak in ib_umem_odp_get()
Date: Tue, 14 Jul 2020 08:08:13 +0200 [thread overview]
Message-ID: <20200714060813.GD657428@kroah.com> (raw)
In-Reply-To: <20200714105748.1151138-1-yangyingliang@huawei.com>
On Tue, Jul 14, 2020 at 10:57:48AM +0000, Yang Yingliang wrote:
> Add missing mmput() on error path to avoid ref-count leak.
>
> This problem has already been resolved in mainline by
> f27a0d50a4bc ("RDMA/umem: Use umem->owning_mm inside ODP").
>
> Fixes: 79bb5b7ee177 ("RDMA/umem: Fix missing mmap_sem in get umem ODP call")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/infiniband/core/umem_odp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
$ ./scripts/get_maintainer.pl --file drivers/infiniband/core/umem_odp.c
Doug Ledford <dledford@redhat.com> (supporter:INFINIBAND SUBSYSTEM)
Jason Gunthorpe <jgg@ziepe.ca> (supporter:INFINIBAND SUBSYSTEM,commit_signer:28/25=100%,authored:17/25=68%,added_lines:453/481=94%,removed_lines:662/722=92%)
Leon Romanovsky <leon@kernel.org> (commit_signer:16/25=64%)
Artemy Kovalyov <artemyko@mellanox.com> (commit_signer:4/25=16%)
Yishai Hadas <yishaih@mellanox.com> (commit_signer:3/25=12%,authored:3/25=12%)
Andrew Morton <akpm@linux-foundation.org> (commit_signer:2/25=8%)
Moni Shoua <monis@mellanox.com> (authored:2/25=8%)
linux-rdma@vger.kernel.org (open list:INFINIBAND SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)
Any reason you ignored the mailing list for the whole IB developer
community?
And you need to make this REALLY obvious that this is a stable-tree-only
patch, for a specific kernel version (and why only that one version),
and a whole lot more description to allow everyone to know what is going
on, and what you expect them to review this for.
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-14 6:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 10:57 [PATCH 4.19] IB/umem: fix reference count leak in ib_umem_odp_get() Yang Yingliang
2020-07-14 6:08 ` Greg KH [this message]
2020-07-14 6:45 ` Yang Yingliang
2020-07-14 11:28 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2020-06-19 16:03 Yang Yingliang
2020-07-13 14:52 ` Greg KH
2020-07-14 2:55 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714060813.GD657428@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).