From: Greg KH <gregkh@linuxfoundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: steven.price@arm.com, james.morse@arm.com, maz@kernel.org,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] KVM: arm64: Fix kvm_reset_vcpu() return code being incorrect" failed to apply to 5.4-stable tree
Date: Tue, 14 Jul 2020 08:08:24 +0200 [thread overview]
Message-ID: <20200714060824.GE657428@kroah.com> (raw)
In-Reply-To: <20200713185901.GG2722994@sasha-vm>
On Mon, Jul 13, 2020 at 02:59:01PM -0400, Sasha Levin wrote:
> On Mon, Jul 13, 2020 at 06:00:59PM +0200, gregkh@linuxfoundation.org wrote:
> >
> > The patch below does not apply to the 5.4-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> >
> > thanks,
> >
> > greg k-h
> >
> > ------------------ original commit in Linus's tree ------------------
> >
> > > From 66b7e05dc0239c5817859f261098ba9cc2efbd2b Mon Sep 17 00:00:00 2001
> > From: Steven Price <steven.price@arm.com>
> > Date: Wed, 17 Jun 2020 11:54:56 +0100
> > Subject: [PATCH] KVM: arm64: Fix kvm_reset_vcpu() return code being incorrect
> > with SVE
> >
> > If SVE is enabled then 'ret' can be assigned the return value of
> > kvm_vcpu_enable_sve() which may be 0 causing future "goto out" sites to
> > erroneously return 0 on failure rather than -EINVAL as expected.
> >
> > Remove the initialisation of 'ret' and make setting the return value
> > explicit to avoid this situation in the future.
> >
> > Fixes: 9a3cdf26e336 ("KVM: arm64/sve: Allow userspace to enable SVE for vcpus")
> > Cc: stable@vger.kernel.org
> > Reported-by: James Morse <james.morse@arm.com>
> > Signed-off-by: Steven Price <steven.price@arm.com>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > Link: https://lore.kernel.org/r/20200617105456.28245-1-steven.price@arm.com
>
> I've worked around not having 540f76d12c66 ("arm64: cpufeature: Add CPU
> capability for AArch32 EL1 support") in 5.7 and 5.4 and queued this
> patch.
Thanks!
prev parent reply other threads:[~2020-07-14 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 16:00 FAILED: patch "[PATCH] KVM: arm64: Fix kvm_reset_vcpu() return code being incorrect" failed to apply to 5.4-stable tree gregkh
2020-07-13 18:59 ` Sasha Levin
2020-07-14 6:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714060824.GE657428@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=maz@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).