From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA9DAC433E5 for ; Tue, 14 Jul 2020 06:08:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AC13221ED for ; Tue, 14 Jul 2020 06:08:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594706906; bh=reHAiOA0n3cDmaoIIM6g+MBRwZK/7y/3DGkJwQOOVoE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XrwDjbZ9cAHBNWFHURMdf0yIAFVYcJrk5BhG8tU3WaKGV69t1fNwc9+DX7iw+evig 2XoNi/+sdrDvrqHiibCRZxWF0+isoK8axfUhg4FURI0KFr59zA2vuXExvz75Z75Wx2 Ces9IB6OBLMQlM1RW2Ki5V1hpKtLt86lcqtICNjM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725788AbgGNGI0 (ORCPT ); Tue, 14 Jul 2020 02:08:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:55508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbgGNGI0 (ORCPT ); Tue, 14 Jul 2020 02:08:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED465221E8; Tue, 14 Jul 2020 06:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594706905; bh=reHAiOA0n3cDmaoIIM6g+MBRwZK/7y/3DGkJwQOOVoE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CmQ6cEq7FP3wRwZrA6eDWP7KL23TcuZQ9pmUcMC/nJ2qGAPwvy4x3ZijpeY7Rc3cS ChWxzWReExwAvsmIPuydLdLBNwUx8M29IUaNhAqLR8HqYdahnwkuU/fuoEKiwg6IXW TlnmqTPK7kQcGaSinpZA1i8dLkZ2WNYSU/494lPc= Date: Tue, 14 Jul 2020 08:08:24 +0200 From: Greg KH To: Sasha Levin Cc: steven.price@arm.com, james.morse@arm.com, maz@kernel.org, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] KVM: arm64: Fix kvm_reset_vcpu() return code being incorrect" failed to apply to 5.4-stable tree Message-ID: <20200714060824.GE657428@kroah.com> References: <1594656059166107@kroah.com> <20200713185901.GG2722994@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200713185901.GG2722994@sasha-vm> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jul 13, 2020 at 02:59:01PM -0400, Sasha Levin wrote: > On Mon, Jul 13, 2020 at 06:00:59PM +0200, gregkh@linuxfoundation.org wrote: > > > > The patch below does not apply to the 5.4-stable tree. > > If someone wants it applied there, or to any other stable or longterm > > tree, then please email the backport, including the original git commit > > id to . > > > > thanks, > > > > greg k-h > > > > ------------------ original commit in Linus's tree ------------------ > > > > > From 66b7e05dc0239c5817859f261098ba9cc2efbd2b Mon Sep 17 00:00:00 2001 > > From: Steven Price > > Date: Wed, 17 Jun 2020 11:54:56 +0100 > > Subject: [PATCH] KVM: arm64: Fix kvm_reset_vcpu() return code being incorrect > > with SVE > > > > If SVE is enabled then 'ret' can be assigned the return value of > > kvm_vcpu_enable_sve() which may be 0 causing future "goto out" sites to > > erroneously return 0 on failure rather than -EINVAL as expected. > > > > Remove the initialisation of 'ret' and make setting the return value > > explicit to avoid this situation in the future. > > > > Fixes: 9a3cdf26e336 ("KVM: arm64/sve: Allow userspace to enable SVE for vcpus") > > Cc: stable@vger.kernel.org > > Reported-by: James Morse > > Signed-off-by: Steven Price > > Signed-off-by: Marc Zyngier > > Link: https://lore.kernel.org/r/20200617105456.28245-1-steven.price@arm.com > > I've worked around not having 540f76d12c66 ("arm64: cpufeature: Add CPU > capability for AArch32 EL1 support") in 5.7 and 5.4 and queued this > patch. Thanks!