From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: linux- stable <stable@vger.kernel.org>,
lkft-triage@lists.linaro.org, Arnd Bergmann <arnd@arndb.de>,
Sasha Levin <sashal@kernel.org>, Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>
Subject: Re: stable-rc 5.4: arm64 build failed - error: ‘const struct arch_timer_erratum_workaround’ has no member named ‘disable_compat_vdso’
Date: Tue, 14 Jul 2020 20:40:13 +0200 [thread overview]
Message-ID: <20200714184013.GA2174489@kroah.com> (raw)
In-Reply-To: <CA+G9fYsLBOVVjxO2DAUgjXskxEXyMpBxYG1PRKwe7BTHJfzfZw@mail.gmail.com>
On Tue, Jul 14, 2020 at 10:48:14PM +0530, Naresh Kamboju wrote:
> arm64 build failed on 5.4
>
> make -sk KBUILD_BUILD_USER=TuxBuild -C/linux -j16 ARCH=arm64
> CROSS_COMPILE=aarch64-linux-gnu- HOSTCC=gcc CC="sccache
> aarch64-linux-gnu-gcc" O=build Image
> #
> ../drivers/clocksource/arm_arch_timer.c:484:4: error: ‘const struct
> arch_timer_erratum_workaround’ has no member named
> ‘disable_compat_vdso’
> 484 | .disable_compat_vdso = true,
> | ^~~~~~~~~~~~~~~~~~~
> ../drivers/clocksource/arm_arch_timer.c:484:26: warning:
> initialization of ‘u32 (*)(void)’ {aka ‘unsigned int (*)(void)’} from
> ‘int’ makes pointer from integer without a cast [-Wint-conversion]
> 484 | .disable_compat_vdso = true,
> | ^~~~
> ../drivers/clocksource/arm_arch_timer.c:484:26: note: (near
> initialization for ‘ool_workarounds[5].read_cntp_tval_el0’)
>
> Could be this patch,
> arm64: arch_timer: Disable the compat vdso for cores affected by
> ARM64_WORKAROUND_1418040
> commit 4b661d6133c5d3a7c9aca0b4ee5a78c7766eff3f upstream.
>
> ARM64_WORKAROUND_1418040 requires that AArch32 EL0 accesses to
> the virtual counter register are trapped and emulated by the kernel.
> This makes the vdso pretty pointless, and in some cases livelock
> prone.
>
> Provide a workaround entry that limits the vdso to 64bit tasks.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/r/20200706163802.1836732-4-maz@kernel.org
> Signed-off-by: Will Deacon <will@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
>
> ref:
> https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/638094006
Thanks, I've now dropped this patch.
greg k-h
next prev parent reply other threads:[~2020-07-14 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 17:18 stable-rc 5.4: arm64 build failed - error: ‘const struct arch_timer_erratum_workaround’ has no member named ‘disable_compat_vdso’ Naresh Kamboju
2020-07-14 18:40 ` Greg Kroah-Hartman [this message]
2020-07-15 6:54 ` Arnd Bergmann
2020-07-15 9:27 ` Greg Kroah-Hartman
2020-07-15 10:16 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714184013.GA2174489@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=lkft-triage@lists.linaro.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).