From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4EDAC433EC for ; Tue, 14 Jul 2020 19:12:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B158223AB for ; Tue, 14 Jul 2020 19:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594753920; bh=Fv54wqq9gp7SGwfYMv7fnezNYr80YqoJFplVUEYpEWY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=t4E2vyVeFpi0jCjGJYZmFdNdspwNUQyfeBc1kac7YTuqjFzKIvW2i1eY3J9M/FJ7p dB6dAHsipmAGhkNH/PSgoNnASCWa/4RyUYYG2K6dP2yNE+Ex36aTstUhIHfn+FgLQD UOH/LbD2tWtj9pfrYksqB8WeFadRB+I/H3Y9Kd6c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729337AbgGNSsD (ORCPT ); Tue, 14 Jul 2020 14:48:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:43316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729878AbgGNSsC (ORCPT ); Tue, 14 Jul 2020 14:48:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3711F22B2C; Tue, 14 Jul 2020 18:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594752481; bh=Fv54wqq9gp7SGwfYMv7fnezNYr80YqoJFplVUEYpEWY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bRTj4875BTsqqSeWdcQcYbosFGbcUN26aaHISW/tRzLZsO/T+L9C4x9LPWZsrfJOs YgdOmZBI1nY7866dDzga3Eyr9SGaZAUbafR6RZB2xP3FvTChOthnlUXkFxqLIL+nvf 2n2GIwrvifNW+FHbyvvSrs+OgNVHp0tykwoIDKfY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andre Edich , Parthiban Veerasooran , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 28/58] smsc95xx: check return value of smsc95xx_reset Date: Tue, 14 Jul 2020 20:44:01 +0200 Message-Id: <20200714184057.534382189@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200714184056.149119318@linuxfoundation.org> References: <20200714184056.149119318@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Andre Edich [ Upstream commit 7c8b1e855f94f88a0c569be6309fc8d5c8844cd1 ] The return value of the function smsc95xx_reset() must be checked to avoid returning false success from the function smsc95xx_bind(). Fixes: 2f7ca802bdae2 ("net: Add SMSC LAN9500 USB2.0 10/100 ethernet adapter driver") Signed-off-by: Andre Edich Signed-off-by: Parthiban Veerasooran Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/smsc95xx.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index c3389bd87c654..145ee4a02a8a5 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -1301,6 +1301,8 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf) /* Init all registers */ ret = smsc95xx_reset(dev); + if (ret) + goto free_pdata; /* detect device revision as different features may be available */ ret = smsc95xx_read_reg(dev, ID_REV, &val); @@ -1331,6 +1333,10 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf) schedule_delayed_work(&pdata->carrier_check, CARRIER_CHECK_DELAY); return 0; + +free_pdata: + kfree(pdata); + return ret; } static void smsc95xx_unbind(struct usbnet *dev, struct usb_interface *intf) -- 2.25.1