From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 999B3C433EC for ; Mon, 20 Jul 2020 15:49:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67D49206E9 for ; Mon, 20 Jul 2020 15:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595260154; bh=FvbEbj9zDmGUluItPBrqCuYmOC1pzcSCb26Tocy+TK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gD9uTWZwMf9Jd2wRPkLREVPKGIhiUYT9UO0pOe98NxFSDqMkaRXNE33/e8BeuD7/j EChha3HQsDoVOoO1IdT/QRNtzO+iiEbDHNPGAG2ubxVfywioOdfsvO+aGz2kFmKIUc aZ98x1FqMS7v/1J3QGyZlR1Kf1uKMFcTe9G7Nlxc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730988AbgGTPtN (ORCPT ); Mon, 20 Jul 2020 11:49:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:45188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730984AbgGTPtM (ORCPT ); Mon, 20 Jul 2020 11:49:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6F132064B; Mon, 20 Jul 2020 15:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595260152; bh=FvbEbj9zDmGUluItPBrqCuYmOC1pzcSCb26Tocy+TK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mKbV+eqtRgEJW6TZn6haY6DfUCLgInu2ytXNdIOL74JX0t8uFGgqnmyTSDetLaop4 zrrkcQh/mCvDuTcSlBkDRIgW6Z9vxbOPhOB4A8VJ5ERXuctHIVV2cFo3mJpMh8U1qB 51VeDu7uIVj+E+LQ06FVcDrG31u13eTSWgbNaup8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+c190f6858a04ea7fbc52@syzkaller.appspotmail.com, Takashi Iwai Subject: [PATCH 4.14 095/125] ALSA: line6: Perform sanity check for each URB creation Date: Mon, 20 Jul 2020 17:37:14 +0200 Message-Id: <20200720152807.614682877@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152802.929969555@linuxfoundation.org> References: <20200720152802.929969555@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Takashi Iwai commit 6e8a914ad619042c5f25a4feb663357c4170fd8d upstream. LINE6 drivers create stream URBs with a fixed pipe without checking its validity, and this may lead to a kernel WARNING at the submission when a malformed USB descriptor is passed. For avoiding the kernel warning, perform the similar sanity checks for each pipe type at creating a URB. Reported-by: syzbot+c190f6858a04ea7fbc52@syzkaller.appspotmail.com Cc: Link: https://lore.kernel.org/r/s5hv9iv4hq8.wl-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/line6/capture.c | 2 ++ sound/usb/line6/playback.c | 2 ++ 2 files changed, 4 insertions(+) --- a/sound/usb/line6/capture.c +++ b/sound/usb/line6/capture.c @@ -291,6 +291,8 @@ int line6_create_audio_in_urbs(struct sn urb->interval = LINE6_ISO_INTERVAL; urb->error_count = 0; urb->complete = audio_in_callback; + if (usb_urb_ep_type_check(urb)) + return -EINVAL; } return 0; --- a/sound/usb/line6/playback.c +++ b/sound/usb/line6/playback.c @@ -436,6 +436,8 @@ int line6_create_audio_out_urbs(struct s urb->interval = LINE6_ISO_INTERVAL; urb->error_count = 0; urb->complete = audio_out_callback; + if (usb_urb_ep_type_check(urb)) + return -EINVAL; } return 0;