From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB1F1C433E4 for ; Mon, 20 Jul 2020 16:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1F3B22D0B for ; Mon, 20 Jul 2020 16:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595262976; bh=w6FnJbW9VA0cfaZ+ntR9YzYW8RYj9D06TOSa5tjzZRc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sBk7snkF9V+bmQJwqkLo2QBzyfPJfiyRn23vI/3N+JcOpU+HyXRBtjvbLdpU1iq9L RQ5xmE3Mcx+MPXcl1ongEzFapUarxGcrvWuVIWwWsDO6HzXm5o/Ns9c2YIHcJp3aVk PQKOoxJbIIXhooXuy/nKoM+qD1cjZFTbLYQgkblI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730125AbgGTQgQ (ORCPT ); Mon, 20 Jul 2020 12:36:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:51632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731158AbgGTPxO (ORCPT ); Mon, 20 Jul 2020 11:53:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 794BD2065E; Mon, 20 Jul 2020 15:53:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595260394; bh=w6FnJbW9VA0cfaZ+ntR9YzYW8RYj9D06TOSa5tjzZRc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QV+wZH4LZ/lpltJVQJcoFiC0GMn4yhwMdu66KbfFwu+I9g1634EwHN+YzYK4Bsaf/ 3IoY6KzdlSST1Lc6eWGyi7Ghnr0C8QlZORLBsP9C5cZEVmt0XpDzahDyD3eLsxNbG2 ucsHPmdZQ3A60lWuifRborrxZg2jkvbUWS+7AOvM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+145012a46658ac00fc9e@syzkaller.appspotmail.com, Alan Stern , Takashi Iwai Subject: [PATCH 4.19 086/133] ALSA: line6: Sync the pending work cancel at disconnection Date: Mon, 20 Jul 2020 17:37:13 +0200 Message-Id: <20200720152807.865066297@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152803.732195882@linuxfoundation.org> References: <20200720152803.732195882@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Takashi Iwai commit 68359a1ad8447c99732ebeab8c169bfed543667a upstream. Recently syzkaller reported a UAF in LINE6 driver, and it's likely because we call cancel_delayed_work() at the disconnect callback instead of cancel_delayed_work_sync(). Let's use the correct one instead. Reported-by: syzbot+145012a46658ac00fc9e@syzkaller.appspotmail.com Suggested-by: Alan Stern Cc: Link: https://lore.kernel.org/r/s5hlfjr4gio.wl-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/line6/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/usb/line6/driver.c +++ b/sound/usb/line6/driver.c @@ -835,7 +835,7 @@ void line6_disconnect(struct usb_interfa if (WARN_ON(usbdev != line6->usbdev)) return; - cancel_delayed_work(&line6->startup_work); + cancel_delayed_work_sync(&line6->startup_work); if (line6->urb_listen != NULL) line6_stop_listen(line6);