From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A57EC433EA for ; Mon, 27 Jul 2020 14:07:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F361520825 for ; Mon, 27 Jul 2020 14:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595858865; bh=957oKhyzfJEsn2BNVCIWxTyGK7q0im7wFaa03N9dAic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uDxMgtpvegcee+hzUn6ddlfg7J4E9hAXgjjFqs2V9WJw93wo5fICe50RCZdeUoRMn ynyrZCQTQPZvaYU62im1bOB0W0tEEM9T71gNR7CEZx6XVS7ampO854C+d+XBvoIWTS PLaikKqi2spTONh9rNWgvsZK0xwDdk0m0kP/K4BI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729291AbgG0OHn (ORCPT ); Mon, 27 Jul 2020 10:07:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:56598 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729281AbgG0OHk (ORCPT ); Mon, 27 Jul 2020 10:07:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B2DD42078E; Mon, 27 Jul 2020 14:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595858860; bh=957oKhyzfJEsn2BNVCIWxTyGK7q0im7wFaa03N9dAic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OplE0zDswr8P2VBeTMKglzRspW3v0rCF7k2v1y4gBFqn0v7l9DMknBmWPAAlTFF6f o+uctx10kDR4e7K8d9GX2x+AceKufviWKHEeBCU5A2MDkXHvr7n3ozjPnzHx9vdRIZ mrKjD+ZeZ1Ned2Ooh5vYVc/FIHe4ml4FWekmMCtw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marc Kleine-Budde , Mark Brown , Sasha Levin Subject: [PATCH 4.14 39/64] regmap: dev_get_regmap_match(): fix string comparison Date: Mon, 27 Jul 2020 16:04:18 +0200 Message-Id: <20200727134913.105979980@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134911.020675249@linuxfoundation.org> References: <20200727134911.020675249@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marc Kleine-Budde [ Upstream commit e84861fec32dee8a2e62bbaa52cded6b05a2a456 ] This function is used by dev_get_regmap() to retrieve a regmap for the specified device. If the device has more than one regmap, the name parameter can be used to specify one. The code here uses a pointer comparison to check for equal strings. This however will probably always fail, as the regmap->name is allocated via kstrdup_const() from the regmap's config->name. Fix this by using strcmp() instead. Signed-off-by: Marc Kleine-Budde Link: https://lore.kernel.org/r/20200703103315.267996-1-mkl@pengutronix.de Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/base/regmap/regmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 013d0a2b3ba0a..4e0cc40ad9ceb 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1242,7 +1242,7 @@ static int dev_get_regmap_match(struct device *dev, void *res, void *data) /* If the user didn't specify a name match any */ if (data) - return (*r)->name == data; + return !strcmp((*r)->name, data); else return 1; } -- 2.25.1