* [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()
@ 2020-08-02 23:28 Ashutosh Dixit
2020-08-03 4:24 ` Greg Kroah-Hartman
2020-08-03 11:12 ` Michael S. Tsirkin
0 siblings, 2 replies; 4+ messages in thread
From: Ashutosh Dixit @ 2020-08-02 23:28 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, mst, sudeep.dutt, arnd, vincent.whitchurch,
stable
Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:
551:58: warning: incorrect type in argument 1 (different address spaces)
551:58: expected void const volatile [noderef] __iomem *addr
551:58: got restricted __le64 *
560:49: warning: incorrect type in argument 1 (different address spaces)
560:49: expected struct mic_device_ctrl *dc
560:49: got struct mic_device_ctrl [noderef] __iomem *dc
579:49: warning: incorrect type in argument 1 (different address spaces)
579:49: expected struct mic_device_ctrl *dc
579:49: got struct mic_device_ctrl [noderef] __iomem *dc
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
drivers/misc/mic/vop/vop_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c
index 85942f6717c5..25ed7d731701 100644
--- a/drivers/misc/mic/vop/vop_main.c
+++ b/drivers/misc/mic/vop/vop_main.c
@@ -546,7 +546,7 @@ static int vop_match_desc(struct device *dev, void *data)
return vdev->desc == (void __iomem *)data;
}
-static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl *dc)
+static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl __iomem *dc)
{
return (struct _vop_vdev *)(unsigned long)readq(&dc->vdev);
}
--
2.26.2.108.g048abe1751
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()
2020-08-02 23:28 [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev() Ashutosh Dixit
@ 2020-08-03 4:24 ` Greg Kroah-Hartman
2020-08-03 4:26 ` Dixit, Ashutosh
2020-08-03 11:12 ` Michael S. Tsirkin
1 sibling, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2020-08-03 4:24 UTC (permalink / raw)
To: Ashutosh Dixit
Cc: linux-kernel, mst, sudeep.dutt, arnd, vincent.whitchurch, stable
On Sun, Aug 02, 2020 at 04:28:12PM -0700, Ashutosh Dixit wrote:
> Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:
>
> 551:58: warning: incorrect type in argument 1 (different address spaces)
> 551:58: expected void const volatile [noderef] __iomem *addr
> 551:58: got restricted __le64 *
> 560:49: warning: incorrect type in argument 1 (different address spaces)
> 560:49: expected struct mic_device_ctrl *dc
> 560:49: got struct mic_device_ctrl [noderef] __iomem *dc
> 579:49: warning: incorrect type in argument 1 (different address spaces)
> 579:49: expected struct mic_device_ctrl *dc
> 579:49: got struct mic_device_ctrl [noderef] __iomem *dc
>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Sudeep Dutt <sudeep.dutt@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
> Cc: stable <stable@vger.kernel.org>
Why is this a stable thing? It doesn't fix a real bug, and sparse
warnings are not needed for stable trees, unless this is the last sparse
warning there.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()
2020-08-03 4:24 ` Greg Kroah-Hartman
@ 2020-08-03 4:26 ` Dixit, Ashutosh
0 siblings, 0 replies; 4+ messages in thread
From: Dixit, Ashutosh @ 2020-08-03 4:26 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, mst, sudeep.dutt, arnd, vincent.whitchurch, stable
On Sun, 02 Aug 2020 21:24:01 -0700, Greg Kroah-Hartman wrote:
>
> On Sun, Aug 02, 2020 at 04:28:12PM -0700, Ashutosh Dixit wrote:
> > Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:
> >
> > 551:58: warning: incorrect type in argument 1 (different address spaces)
> > 551:58: expected void const volatile [noderef] __iomem *addr
> > 551:58: got restricted __le64 *
> > 560:49: warning: incorrect type in argument 1 (different address spaces)
> > 560:49: expected struct mic_device_ctrl *dc
> > 560:49: got struct mic_device_ctrl [noderef] __iomem *dc
> > 579:49: warning: incorrect type in argument 1 (different address spaces)
> > 579:49: expected struct mic_device_ctrl *dc
> > 579:49: got struct mic_device_ctrl [noderef] __iomem *dc
> >
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Cc: Sudeep Dutt <sudeep.dutt@intel.com>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
> > Cc: stable <stable@vger.kernel.org>
>
> Why is this a stable thing? It doesn't fix a real bug, and sparse
> warnings are not needed for stable trees, unless this is the last sparse
> warning there.
It is the last sparse warning. Sorry I wasn't sure about stable so I
thought might as well. Please ignore if it's not required. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()
2020-08-02 23:28 [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev() Ashutosh Dixit
2020-08-03 4:24 ` Greg Kroah-Hartman
@ 2020-08-03 11:12 ` Michael S. Tsirkin
1 sibling, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2020-08-03 11:12 UTC (permalink / raw)
To: Ashutosh Dixit
Cc: linux-kernel, Greg Kroah-Hartman, sudeep.dutt, arnd,
vincent.whitchurch, stable
On Sun, Aug 02, 2020 at 04:28:12PM -0700, Ashutosh Dixit wrote:
> Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:
>
> 551:58: warning: incorrect type in argument 1 (different address spaces)
> 551:58: expected void const volatile [noderef] __iomem *addr
> 551:58: got restricted __le64 *
> 560:49: warning: incorrect type in argument 1 (different address spaces)
> 560:49: expected struct mic_device_ctrl *dc
> 560:49: got struct mic_device_ctrl [noderef] __iomem *dc
> 579:49: warning: incorrect type in argument 1 (different address spaces)
> 579:49: expected struct mic_device_ctrl *dc
> 579:49: got struct mic_device_ctrl [noderef] __iomem *dc
>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Sudeep Dutt <sudeep.dutt@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/misc/mic/vop/vop_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c
> index 85942f6717c5..25ed7d731701 100644
> --- a/drivers/misc/mic/vop/vop_main.c
> +++ b/drivers/misc/mic/vop/vop_main.c
> @@ -546,7 +546,7 @@ static int vop_match_desc(struct device *dev, void *data)
> return vdev->desc == (void __iomem *)data;
> }
>
> -static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl *dc)
> +static struct _vop_vdev *vop_dc_to_vdev(struct mic_device_ctrl __iomem *dc)
> {
> return (struct _vop_vdev *)(unsigned long)readq(&dc->vdev);
> }
> --
> 2.26.2.108.g048abe1751
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-03 11:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-02 23:28 [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev() Ashutosh Dixit
2020-08-03 4:24 ` Greg Kroah-Hartman
2020-08-03 4:26 ` Dixit, Ashutosh
2020-08-03 11:12 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).