From: Greg KH <greg@kroah.com>
To: Huacai Chen <chenhc@lemote.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
kvm@vger.kernel.org, linux-mips@vger.kernel.org,
Fuxin Zhang <zhangfx@lemote.com>,
Huacai Chen <chenhuacai@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: VZ: Only include loongson_regs.h for CPU_LOONGSON64
Date: Sat, 8 Aug 2020 17:31:23 +0200 [thread overview]
Message-ID: <20200808153123.GC369184@kroah.com> (raw)
In-Reply-To: <1596891052-24052-1-git-send-email-chenhc@lemote.com>
On Sat, Aug 08, 2020 at 08:50:52PM +0800, Huacai Chen wrote:
> Only Loongson64 platform has and needs loongson_regs.h, including it
> unconditionally will cause build errors.
>
> Fixes: 7f2a83f1c2a941ebfee5 ("KVM: MIPS: Add CPUCFG emulation for Loongson-3")
> Cc: stable@vger.kernel.org
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
> arch/mips/kvm/vz.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/kvm/vz.c b/arch/mips/kvm/vz.c
> index 3932f76..a474578 100644
> --- a/arch/mips/kvm/vz.c
> +++ b/arch/mips/kvm/vz.c
> @@ -29,7 +29,9 @@
> #include <linux/kvm_host.h>
>
> #include "interrupt.h"
> +#ifdef CONFIG_CPU_LOONGSON64
> #include "loongson_regs.h"
> +#endif
The fix for this should be in the .h file, no #ifdef should be needed in
a .c file.
thanks,
greg k-h
next prev parent reply other threads:[~2020-08-08 15:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 12:50 [PATCH] MIPS: VZ: Only include loongson_regs.h for CPU_LOONGSON64 Huacai Chen
2020-08-08 15:31 ` Greg KH [this message]
2020-08-08 15:35 ` Jiaxun Yang
2020-08-09 7:02 ` Greg KH
2020-08-09 17:23 ` Paolo Bonzini
2020-08-09 17:38 ` Sasha Levin
2020-08-09 17:45 ` Sasha Levin
2020-08-10 7:44 ` Greg KH
2020-08-10 8:56 ` Paolo Bonzini
2020-08-10 9:03 ` Greg KH
2020-08-10 9:29 ` Jiaxun Yang
2020-08-10 9:31 ` Thomas Bogendoerfer
2020-08-22 18:24 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808153123.GC369184@kroah.com \
--to=greg@kroah.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox