From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF02DC433DF for ; Sat, 15 Aug 2020 23:07:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B19DA206B6 for ; Sat, 15 Aug 2020 23:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597532838; bh=vbDlWWWieOXnPlFIM98LP93HYAdkUHUPdDyNGIA1rkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LTYiWxK66aLj10EFkD7LfqAqLP0pz3ocrPSUnA4TYVfCaGScYmc4MbPu70gF4JFEa idirz1CJImPaRj+Yl7u4OTPJUOyaeeAepsw2/E9buyG3dX3vmvlccWZ9/5gw+1JRTy QLeZ75pd6lINvyMMy8nYtRIYCnhE+bsPyquL7Csg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726729AbgHOXHR (ORCPT ); Sat, 15 Aug 2020 19:07:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:59998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726357AbgHOXHR (ORCPT ); Sat, 15 Aug 2020 19:07:17 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F263A206B2; Sat, 15 Aug 2020 23:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597532837; bh=vbDlWWWieOXnPlFIM98LP93HYAdkUHUPdDyNGIA1rkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tILIil1E1gh1U4rHqJMpKtxCiRk+RUvOsq7ob2CxNvfn8BOMbjJBfHUXGj6ub45KF grpc2EinPRBT71ti9AtpyX04YC2w4U29lRyekgF0Uj+gk6bGvwqV9aNdm3d/PcUSNe QkqCc4XQ5JQsc3/W8jPUJH3hLHt/5Gj3sSSmWN+Q= Date: Sat, 15 Aug 2020 19:07:15 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jim Cromie , jbaron@akamai.com Subject: Re: [PATCH AUTOSEL 5.7 52/60] dyndbg: prefer declarative init in caller, to memset in callee Message-ID: <20200815230715.GT2975990@sasha-vm> References: <20200810191028.3793884-1-sashal@kernel.org> <20200810191028.3793884-52-sashal@kernel.org> <20200811051332.GA1237801@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200811051332.GA1237801@kroah.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Aug 11, 2020 at 07:13:32AM +0200, Greg Kroah-Hartman wrote: >On Mon, Aug 10, 2020 at 03:10:20PM -0400, Sasha Levin wrote: >> From: Jim Cromie >> >> [ Upstream commit 9c9d0acbe2793315fa6945a19685ad2a51fb281b ] >> >> ddebug_exec_query declares an auto var, and passes it to >> ddebug_parse_query, which memsets it before using it. Drop that >> memset, instead initialize the variable in the caller; let the >> compiler decide how to do it. >> >> Acked-by: >> Signed-off-by: Jim Cromie >> Link: https://lore.kernel.org/r/20200719231058.1586423-10-jim.cromie@gmail.com >> Signed-off-by: Greg Kroah-Hartman >> Signed-off-by: Sasha Levin >> --- >> lib/dynamic_debug.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c >> index e3755d1f74bd2..4f0bd560478f7 100644 >> --- a/lib/dynamic_debug.c >> +++ b/lib/dynamic_debug.c >> @@ -327,7 +327,6 @@ static int ddebug_parse_query(char *words[], int nwords, >> pr_err("expecting pairs of match-spec \n"); >> return -EINVAL; >> } >> - memset(query, 0, sizeof(*query)); >> >> if (modname) >> /* support $modname.dyndbg= */ >> @@ -445,7 +444,7 @@ static int ddebug_parse_flags(const char *str, unsigned int *flagsp, >> static int ddebug_exec_query(char *query_string, const char *modname) >> { >> unsigned int flags = 0, mask = 0; >> - struct ddebug_query query; >> + struct ddebug_query query = {}; >> #define MAXWORDS 9 >> int nwords, nfound; >> char *words[MAXWORDS]; >> -- >> 2.25.1 >> > >There's no need for this in stable kernels, please drop it from >everywhere. Dropped, thanks! -- Thanks, Sasha