From: Kees Cook <keescook@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: "Sami Tolvanen" <samitolvanen@google.com>,
"Arvind Sankar" <nivedita@alum.mit.edu>,
"Sedat Dilek" <sedat.dilek@gmail.com>,
"Fangrui Song" <maskray@google.com>,
"Joe Perches" <joe@perches.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Dávid Bolvanský" <david.bolvansky@gmail.com>,
"Eli Friedman" <efriedma@quicinc.com>,
"# 3.4.x" <stable@vger.kernel.org>,
"Vishal Verma" <vishal.l.verma@intel.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Joel Fernandes (Google)" <joel@joelfernandes.org>,
"Daniel Axtens" <dja@axtens.net>,
"Ingo Molnar" <mingo@kernel.org>,
"Yury Norov" <yury.norov@gmail.com>,
"Alexandru Ardelean" <alexandru.ardelean@analog.com>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Nathan Chancellor" <natechancellor@gmail.com>
Subject: Re: [PATCH v2] lib/string.c: implement stpcpy
Date: Mon, 17 Aug 2020 12:15:20 -0700 [thread overview]
Message-ID: <202008171213.CBCFF5D67@keescook> (raw)
In-Reply-To: <CAKwvOd=Ns4_+amT8P-7yQ56xUdDmL=1zDUThF-OmFKhexhJPdg@mail.gmail.com>
On Mon, Aug 17, 2020 at 11:36:49AM -0700, Nick Desaulniers wrote:
> That said, this libcall optimization/transformation (sprintf->stpcpy)
> does look useful to me. Kees, do you have thoughts on me providing
> the implementation without exposing it in a header vs using
> -fno-builtin-stpcpy? (I would need to add the missing EXPORT_SYMBOL,
> as pointed out by 0day bot and on the github thread). I don't care
> either way; I'd just like your input before sending a V+1. Maybe
> better to just not implement it and never implement it?
I think I would ultimately prefer -fno-builtin-stpcpy, but for now,
sure, an implementation without a header (and a biiig comment above it
detailing why and a reference to the bug) would be fine by me.
--
Kees Cook
next prev parent reply other threads:[~2020-08-17 19:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 0:24 [PATCH] lib/string.c: implement stpcpy Nick Desaulniers
2020-08-15 0:52 ` Joe Perches
2020-08-15 2:00 ` Nick Desaulniers
2020-08-15 0:53 ` Sami Tolvanen
2020-08-15 1:33 ` Arvind Sankar
2020-08-15 1:40 ` Arvind Sankar
2020-08-15 2:09 ` [PATCH v2] " Nick Desaulniers
2020-08-15 2:58 ` Arvind Sankar
2020-08-15 3:42 ` Joe Perches
2020-08-15 16:34 ` Kees Cook
2020-08-15 17:38 ` Dávid Bolvanský
2020-08-15 20:47 ` Nick Desaulniers
2020-08-15 21:23 ` Joe Perches
2020-08-15 21:27 ` Dávid Bolvanský
2020-08-15 21:28 ` Nick Desaulniers
2020-08-15 21:31 ` Joe Perches
2020-08-15 22:17 ` Nick Desaulniers
2020-08-16 0:19 ` Fangrui Song
2020-08-16 5:22 ` Sedat Dilek
2020-08-16 15:02 ` Arvind Sankar
2020-08-17 17:14 ` Sami Tolvanen
2020-08-17 18:36 ` Nick Desaulniers
2020-08-17 19:15 ` Kees Cook [this message]
2020-08-17 20:13 ` Arvind Sankar
2020-08-17 21:45 ` Nick Desaulniers
[not found] ` <77557c29286140dea726cc334b4f59fc@AcuMS.aculab.com>
2020-08-18 8:32 ` Joe Perches
2020-08-17 19:16 ` Kees Cook
2020-08-16 7:44 ` kernel test robot
2020-08-15 2:00 ` [PATCH] " Nick Desaulniers
2020-08-15 22:17 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008171213.CBCFF5D67@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=alexandru.ardelean@analog.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dan.j.williams@intel.com \
--cc=david.bolvansky@gmail.com \
--cc=dja@axtens.net \
--cc=efriedma@quicinc.com \
--cc=joe@perches.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=maskray@google.com \
--cc=mingo@kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=samitolvanen@google.com \
--cc=sedat.dilek@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).