From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8622C433E3 for ; Thu, 20 Aug 2020 11:23:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86A90208E4 for ; Thu, 20 Aug 2020 11:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597922617; bh=nPF0txjiELBv6Oz5GF2WpnSDI0mKS6IXhMWkN0onJKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=R0q9htGXxDO+5o8doDGLx2vT6I573aOqYd2J1s4Z40uPb9z/I7sJBd0ormMPMeNAt StxlgXFWGicvEhmPMIgGq52GdLcPY6MNYRRny9/ErHLj+xdA67u614vimWfsz6U/x/ VxerSVyc6HyVzGxHTu+cCB3XOjbR1lTLm76Zcvd4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729662AbgHTLXa (ORCPT ); Thu, 20 Aug 2020 07:23:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:36910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730536AbgHTKHH (ORCPT ); Thu, 20 Aug 2020 06:07:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C2B120724; Thu, 20 Aug 2020 10:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597918026; bh=nPF0txjiELBv6Oz5GF2WpnSDI0mKS6IXhMWkN0onJKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RPwuyLsOkRAjl8esc+YUotxYzVT5rgHv6JxeejqM/zeaX7jzvg/tz8P1u5aLFNHJm Eha6/tyELYeXQ9bQQbG93inEPyhlYISvU487tBkw7ccxOR/SJznPbIVP9GiNicekm/ E/qPDohMNneX1ySGlYlh4KcXaIOCBbiPwWY0GGhM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ben Skeggs , Sasha Levin Subject: [PATCH 4.14 020/228] drm/nouveau/fbcon: fix module unload when fbcon init has failed for some reason Date: Thu, 20 Aug 2020 11:19:55 +0200 Message-Id: <20200820091608.542688736@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820091607.532711107@linuxfoundation.org> References: <20200820091607.532711107@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Ben Skeggs [ Upstream commit 498595abf5bd51f0ae074cec565d888778ea558f ] Stale pointer was tripping up the unload path. Signed-off-by: Ben Skeggs Signed-off-by: Sasha Levin --- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index 2b12d82aac150..ee8f744dc4881 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -543,6 +543,7 @@ fini: drm_fb_helper_fini(&fbcon->helper); free: kfree(fbcon); + drm->fbcon = NULL; return ret; } -- 2.25.1