From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC034C433E1 for ; Thu, 20 Aug 2020 10:29:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD95E20658 for ; Thu, 20 Aug 2020 10:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597919355; bh=+W1ClYTS8nfE7NN7MjHwbLixXM3LcbIFD2L7yU6ukJc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xbcFsAstY6PlYSdeQwsr7soEmWLdmWzmvGdKxB4kDbV0LF5XkkVl1mQxntGVkz0SG u95z+/6bWesuOb0rrLvoxG27ffX0aMt6RbP87sKavV+Dq/jpAmL1QWfuo3UMY9UM8t /ucUH3b9X/AmS16PSWBtz8EHFl5FrBVYMOkF1jUU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728694AbgHTK3P (ORCPT ); Thu, 20 Aug 2020 06:29:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:47792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730519AbgHTKVW (ORCPT ); Thu, 20 Aug 2020 06:21:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4AF420885; Thu, 20 Aug 2020 10:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597918881; bh=+W1ClYTS8nfE7NN7MjHwbLixXM3LcbIFD2L7yU6ukJc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a9SWIfWvbeTIQWzFegQ+vNg675CY+JsMbKkvA7s8q24Dz8DQ7i0OK8rQ0ffJFStBG TF5j3Ca2lA88l8p89WeciTu4lejFitRmRLe/u/Nle6IvhHxRDox20vpeJ4FNGhhNNE D6XYz9+l7X4sxTwuiU89nfOubBnLRtaESTc5Nrgk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julian Wiedmann , Alexandra Winter , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 099/149] s390/qeth: dont process empty bridge port events Date: Thu, 20 Aug 2020 11:22:56 +0200 Message-Id: <20200820092130.507259086@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820092125.688850368@linuxfoundation.org> References: <20200820092125.688850368@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Julian Wiedmann [ Upstream commit 02472e28b9a45471c6d8729ff2c7422baa9be46a ] Discard events that don't contain any entries. This shouldn't happen, but subsequent code relies on being able to use entry 0. So better be safe than accessing garbage. Fixes: b4d72c08b358 ("qeth: bridgeport support - basic control") Signed-off-by: Julian Wiedmann Reviewed-by: Alexandra Winter Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/s390/net/qeth_l2_main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c index 97211f7f0cf02..ed4b0f6e2d6ad 100644 --- a/drivers/s390/net/qeth_l2_main.c +++ b/drivers/s390/net/qeth_l2_main.c @@ -1669,6 +1669,10 @@ static void qeth_bridge_state_change(struct qeth_card *card, int extrasize; QETH_CARD_TEXT(card, 2, "brstchng"); + if (qports->num_entries == 0) { + QETH_CARD_TEXT(card, 2, "BPempty"); + return; + } if (qports->entry_length != sizeof(struct qeth_sbp_port_entry)) { QETH_CARD_TEXT_(card, 2, "BPsz%04x", qports->entry_length); return; -- 2.25.1