Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	"# 3.4.x" <stable@vger.kernel.org>,
	clang-built-linux <clang-built-linux@googlegroups.com>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Dmitry Golovin <dima@golovin.in>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Fangrui Song <maskray@google.com>,
	Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: LLVM=1 patches for 5.4
Date: Thu, 20 Aug 2020 13:44:45 -0700	[thread overview]
Message-ID: <202008201339.879ABA0@keescook> (raw)
In-Reply-To: <CAKwvOd=ojdFXs1ceoBwSnFBzyP7PW+-AknF0WjgJix60BKdgZQ@mail.gmail.com>

On Thu, Aug 20, 2020 at 01:27:32PM -0700, Nick Desaulniers wrote:
> On Thu, Aug 20, 2020 at 1:14 PM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> 
> Oh, I almost forgot, here's a picture of my cat who helped me by
> trying to lay on my keyboard mid-interactive rebase of this series.
> https://photos.app.goo.gl/J7CtBJtHmiuzhSfq7
> I asked him nicely to move; he proceeded to bite me, and not comply.

I think this needs to be an ongoing change to the stable kernel process.
Since such things require documentation, I propose:


diff --git a/Documentation/process/stable-kernel-rules.rst b/Documentation/process/stable-kernel-rules.rst
index 06f743b612c4..928f6f3ce6e2 100644
--- a/Documentation/process/stable-kernel-rules.rst
+++ b/Documentation/process/stable-kernel-rules.rst
@@ -35,6 +35,7 @@ Rules on what kind of patches are accepted, and which ones are not, into the
 Procedure for submitting patches to the -stable tree
 ----------------------------------------------------
 
+ - Preference may be given to submissions featuring pictures of cats. Also dogs.
  - If the patch covers files in net/ or drivers/net please follow netdev stable
    submission guidelines as described in
    :ref:`Documentation/networking/netdev-FAQ.rst <netdev-FAQ>`


> > Dear stable kernel maintainers,
> > Please consider the attached mbox file, which contains 9 patches which
> > cherry pick cleanly onto 5.4:
> >
> > 1. commit fcf1b6a35c16 ("Documentation/llvm: add documentation on
> > building w/ Clang/LLVM")
> > 2. commit 0f44fbc162b7 ("Documentation/llvm: fix the name of llvm-size")
> > 3. commit 63b903dfebde ("net: wan: wanxl: use allow to pass
> > CROSS_COMPILE_M68k for rebuilding firmware")
> > 4. commit 734f3719d343 ("net: wan: wanxl: use $(M68KCC) instead of
> > $(M68KAS) for rebuilding firmware")
> > 5. commit eefb8c124fd9 ("x86/boot: kbuild: allow readelf executable to
> > be specified")
> > 6. commit 94f7345b7124 ("kbuild: remove PYTHON2 variable")
> > 7. commit aa824e0c962b ("kbuild: remove AS variable")
> > 8. commit 7e20e47c70f8 ("kbuild: replace AS=clang with LLVM_IAS=1")
> > 9. commit a0d1c951ef08 ("kbuild: support LLVM=1 to switch the default
> > tools to Clang/LLVM")

And FWIW, "yes please" from me as well. This makes things muuuch easier
to test LTS with Clang.

-- 
Kees Cook

  reply	other threads:[~2020-08-20 20:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 20:14 LLVM=1 patches for 5.4 Nick Desaulniers
2020-08-20 20:27 ` Nick Desaulniers
2020-08-20 20:44   ` Kees Cook [this message]
2020-08-24  8:10 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202008201339.879ABA0@keescook \
    --to=keescook@chromium.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=dima@golovin.in \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=masahiroy@kernel.org \
    --cc=maskray@google.com \
    --cc=natechancellor@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=sashal@kernel.org \
    --cc=sedat.dilek@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox