* [PATCH] Ignore UAS for JMicron JMS567 ATA/ATAPI Bridge
[not found] <20200824074027.GB3983120@kroah.com>
@ 2020-08-24 17:31 ` Cyril Roelandt
2020-08-24 20:18 ` Alan Stern
0 siblings, 1 reply; 3+ messages in thread
From: Cyril Roelandt @ 2020-08-24 17:31 UTC (permalink / raw)
To: linux-usb
Cc: stern, sellis, pachoramos, labbott, javhera, brice.goglin,
Cyril Roelandt, stable
This device does not support UAS properly and a similar entry already
exists in drivers/usb/storage/unusual_uas.h. Without this patch,
storage_probe() defers the handling of this device to UAS, which cannot
handle it either.
Tested-by: Brice Goglin <brice.goglin@gmail.com>
CC: <stable@vger.kernel.org>
---
drivers/usb/storage/unusual_devs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 220ae2c356ee..5732e9691f08 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -2328,7 +2328,7 @@ UNUSUAL_DEV( 0x357d, 0x7788, 0x0114, 0x0114,
"JMicron",
"USB to ATA/ATAPI Bridge",
USB_SC_DEVICE, USB_PR_DEVICE, NULL,
- US_FL_BROKEN_FUA ),
+ US_FL_BROKEN_FUA | US_FL_IGNORE_UAS ),
/* Reported by Andrey Rahmatullin <wrar@altlinux.org> */
UNUSUAL_DEV( 0x4102, 0x1020, 0x0100, 0x0100,
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Ignore UAS for JMicron JMS567 ATA/ATAPI Bridge
2020-08-24 17:31 ` [PATCH] Ignore UAS for JMicron JMS567 ATA/ATAPI Bridge Cyril Roelandt
@ 2020-08-24 20:18 ` Alan Stern
2020-08-25 21:22 ` [PATCH v2] " Cyril Roelandt
0 siblings, 1 reply; 3+ messages in thread
From: Alan Stern @ 2020-08-24 20:18 UTC (permalink / raw)
To: Cyril Roelandt
Cc: linux-usb, sellis, pachoramos, labbott, javhera, brice.goglin,
stable
On Mon, Aug 24, 2020 at 07:31:28PM +0200, Cyril Roelandt wrote:
> This device does not support UAS properly and a similar entry already
> exists in drivers/usb/storage/unusual_uas.h. Without this patch,
> storage_probe() defers the handling of this device to UAS, which cannot
> handle it either.
>
> Tested-by: Brice Goglin <brice.goglin@gmail.com>
> CC: <stable@vger.kernel.org>
You left out the Signed-off-by: tag and a Fixes: tag. Please resend the
patch with those tags. When you do, you may add:
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Alan Stern
> ---
> drivers/usb/storage/unusual_devs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 220ae2c356ee..5732e9691f08 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -2328,7 +2328,7 @@ UNUSUAL_DEV( 0x357d, 0x7788, 0x0114, 0x0114,
> "JMicron",
> "USB to ATA/ATAPI Bridge",
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> - US_FL_BROKEN_FUA ),
> + US_FL_BROKEN_FUA | US_FL_IGNORE_UAS ),
>
> /* Reported by Andrey Rahmatullin <wrar@altlinux.org> */
> UNUSUAL_DEV( 0x4102, 0x1020, 0x0100, 0x0100,
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] Ignore UAS for JMicron JMS567 ATA/ATAPI Bridge
2020-08-24 20:18 ` Alan Stern
@ 2020-08-25 21:22 ` Cyril Roelandt
0 siblings, 0 replies; 3+ messages in thread
From: Cyril Roelandt @ 2020-08-25 21:22 UTC (permalink / raw)
To: linux-usb
Cc: stern, sellis, pachoramos, labbott, javhera, brice.goglin,
Cyril Roelandt, stable
This device does not support UAS properly and a similar entry already
exists in drivers/usb/storage/unusual_uas.h. Without this patch,
storage_probe() defers the handling of this device to UAS, which cannot
handle it either.
Tested-by: Brice Goglin <brice.goglin@gmail.com>
Fixes: bc3bdb12bbb3 ("usb-storage: Disable UAS on JMicron SATA enclosure")
Acked-by: Alan Stern <stern@rowland.harvard.edu>
CC: <stable@vger.kernel.org>
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
---
drivers/usb/storage/unusual_devs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 220ae2c356ee..5732e9691f08 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -2328,7 +2328,7 @@ UNUSUAL_DEV( 0x357d, 0x7788, 0x0114, 0x0114,
"JMicron",
"USB to ATA/ATAPI Bridge",
USB_SC_DEVICE, USB_PR_DEVICE, NULL,
- US_FL_BROKEN_FUA ),
+ US_FL_BROKEN_FUA | US_FL_IGNORE_UAS ),
/* Reported by Andrey Rahmatullin <wrar@altlinux.org> */
UNUSUAL_DEV( 0x4102, 0x1020, 0x0100, 0x0100,
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-25 21:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200824074027.GB3983120@kroah.com>
2020-08-24 17:31 ` [PATCH] Ignore UAS for JMicron JMS567 ATA/ATAPI Bridge Cyril Roelandt
2020-08-24 20:18 ` Alan Stern
2020-08-25 21:22 ` [PATCH v2] " Cyril Roelandt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).