From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60387C433E2 for ; Thu, 3 Sep 2020 19:01:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 446A7208C7 for ; Thu, 3 Sep 2020 19:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599159668; bh=4O6wT3KPGrg/7msyepJfuWPtvetcJ8fPChc5bMkiIrA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VjLpv5363ytEmxvuWQLTsJaiQJtGKE5kfTsKdNoYlo0APczmEaOPn5lyKdmInjgpU J644VzQjb+p4s15o2OM8AjqQZ510mcBEpsAfgGp1uGnX+wLiRLkl1ZKZJ4Ty+DU9a4 zB8/qbTx3Ufb9frSW+CCqv8pvMzxEGYzpOXoi7Ns= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728312AbgICTBG (ORCPT ); Thu, 3 Sep 2020 15:01:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:58630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726678AbgICTBE (ORCPT ); Thu, 3 Sep 2020 15:01:04 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F26F20658; Thu, 3 Sep 2020 19:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599159663; bh=4O6wT3KPGrg/7msyepJfuWPtvetcJ8fPChc5bMkiIrA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t39wwSvXzeRu5vDYWQGxEtsdGalBK7iodUh85dwnnMd3ptYEDGhQJIoURNHoE8Bg7 pTgZF3w9f2sCIqisgmil4hHmRZMoXAQnAWZwtkA60wVUY34YKpRFp6zM4jpUBrgiQ3 zWLB6Lp8QczXH2Rn4LYdQoMIi/gykFg+lDQjt7Qk= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 5DF3540D3D; Thu, 3 Sep 2020 16:01:01 -0300 (-03) Date: Thu, 3 Sep 2020 16:01:01 -0300 From: Arnaldo Carvalho de Melo To: Kim Phillips Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Stephane Eranian , Alexey Budankov , Tony Jones , Jin Yao , Ian Rogers , "Paul A. Clarke" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] perf record/stat: Explicitly call out event modifiers in the documentation Message-ID: <20200903190101.GH3495158@kernel.org> References: <20200901215853.276234-1-kim.phillips@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200901215853.276234-1-kim.phillips@amd.com> X-Url: http://acmel.wordpress.com Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Em Tue, Sep 01, 2020 at 04:58:53PM -0500, Kim Phillips escreveu: > Event modifiers are not mentioned in the perf record or perf stat > manpages. Add them to orient new users more effectively by pointing > them to the perf list manpage for details. Thanks, applied. - Arnaldo > Signed-off-by: Kim Phillips > Fixes: 2055fdaf8703 ("perf list: Document precise event sampling for AMD IBS") > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Adrian Hunter > Cc: Stephane Eranian > Cc: Alexey Budankov > Cc: Tony Jones > Cc: Jin Yao > Cc: Ian Rogers > Cc: "Paul A. Clarke" > Cc: linux-perf-users@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: stable@vger.kernel.org > --- > tools/perf/Documentation/perf-record.txt | 4 ++++ > tools/perf/Documentation/perf-stat.txt | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt > index 3f72d8e261f3..bd50cdff08a8 100644 > --- a/tools/perf/Documentation/perf-record.txt > +++ b/tools/perf/Documentation/perf-record.txt > @@ -33,6 +33,10 @@ OPTIONS > - a raw PMU event (eventsel+umask) in the form of rNNN where NNN is a > hexadecimal event descriptor. > > + - a symbolic or raw PMU event followed by an optional colon > + and a list of event modifiers, e.g., cpu-cycles:p. See the > + linkperf:perf-list[1] man page for details on event modifiers. > + > - a symbolically formed PMU event like 'pmu/param1=0x3,param2/' where > 'param1', 'param2', etc are defined as formats for the PMU in > /sys/bus/event_source/devices//format/*. > diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt > index c9bfefc051fb..a4b1d11fefc8 100644 > --- a/tools/perf/Documentation/perf-stat.txt > +++ b/tools/perf/Documentation/perf-stat.txt > @@ -39,6 +39,10 @@ report:: > - a raw PMU event (eventsel+umask) in the form of rNNN where NNN is a > hexadecimal event descriptor. > > + - a symbolic or raw PMU event followed by an optional colon > + and a list of event modifiers, e.g., cpu-cycles:p. See the > + linkperf:perf-list[1] man page for details on event modifiers. > + > - a symbolically formed event like 'pmu/param1=0x3,param2/' where > param1 and param2 are defined as formats for the PMU in > /sys/bus/event_source/devices//format/* > -- > 2.27.0 > -- - Arnaldo