From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F827C433E2 for ; Tue, 8 Sep 2020 22:23:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C915A20936 for ; Tue, 8 Sep 2020 22:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728631AbgIHWXW convert rfc822-to-8bit (ORCPT ); Tue, 8 Sep 2020 18:23:22 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:59406 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728463AbgIHWXV (ORCPT ); Tue, 8 Sep 2020 18:23:21 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 316341C0B87; Wed, 9 Sep 2020 00:23:19 +0200 (CEST) Date: Wed, 9 Sep 2020 00:23:18 +0200 From: Pavel Machek To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Joonas Lahtinen , stable@vger.kernel.org Subject: Re: [PATCH 1/2] drm/i915/gem: Replace reloc chain with terminator on error unwind Message-ID: <20200908222318.GD1005@bug> References: <20200819103952.19083-1-chris@chris-wilson.co.uk> <20200819172331.GA4796@amd> <159785861047.667.10730572472834322633@build.alporthouse.com> <20200819193326.p62h2dj7jpzfkeyy@duo.ucw.cz> <159790897155.667.4491040035549523476@build.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <159790897155.667.4491040035549523476@build.alporthouse.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi! > > > > Thanks for the patches. I assume this should fix problem from > > > > "5.9-rc1: graphics regression moved from -next to mainline" thread. > > > > > > > > I have applied them over current -next, and my machine seems to be > > > > working so far (but uptime is less than 30 minutes). > > > > > > > > If the machine still works tommorow, I'll assume problem is solved. > > > > > > Aye, best wait until we have to start competing with Chromium for > > > memory... The suspicion is that it was the resource allocation failure > > > path. > > > > Yep, my machines are low on memory. > > > > But ... test did not work that well. I have dead X and blinking > > screen. Machine still works reasonably well over ssh, so I guess > > that's an improvement. > > Well my last remaining 32bit gen3 device is currently pushing up the > daises, so could you try removing the attempt to use WC? Something like > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > @@ -955,10 +955,7 @@ static u32 *__reloc_gpu_map(struct reloc_cache *cache, > { > u32 *map; > > - map = i915_gem_object_pin_map(pool->obj, > - cache->has_llc ? > - I915_MAP_FORCE_WB : > - I915_MAP_FORCE_WC); > + map = i915_gem_object_pin_map(pool->obj, I915_MAP_FORCE_WB); > > on top of the previous patch. Faultinjection didn't turn up anything in > eb_relocate_vma, so we need to dig deeper. With this on top of other patches, it works. Tested-by: Pavel Machek Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html