From: Greg KH <gregkh@linuxfoundation.org>
To: Mike Snitzer <snitzer@redhat.com>
Cc: ming.lei@redhat.com, stable@vger.kernel.org
Subject: Re: [PATCH 5.4, 5.8] dm: fix bio splitting and its bio completion order for regular IO
Date: Mon, 28 Sep 2020 19:52:29 +0200 [thread overview]
Message-ID: <20200928175229.GA2202997@kroah.com> (raw)
In-Reply-To: <20200928173144.GA2042505@kroah.com>
On Mon, Sep 28, 2020 at 07:31:44PM +0200, Greg KH wrote:
> On Mon, Sep 28, 2020 at 11:29:41AM -0400, Mike Snitzer wrote:
> > This backport applies (with mild offset) to both v5.4.67 and v5.8.11:
> >
> > >From ee1dfad5325ff1cfb2239e564cd411b3bfe8667a Mon Sep 17 00:00:00 2001
> > From: Mike Snitzer <snitzer@redhat.com>
> > Date: Mon, 14 Sep 2020 13:04:19 -0400
> > Subject: [PATCH] dm: fix bio splitting and its bio completion order for regular IO
> >
> > dm_queue_split() is removed because __split_and_process_bio() _must_
> > handle splitting bios to ensure proper bio submission and completion
> > ordering as a bio is split.
> >
> > Otherwise, multiple recursive calls to ->submit_bio will cause multiple
> > split bios to be allocated from the same ->bio_split mempool at the same
> > time. This would result in deadlock in low memory conditions because no
> > progress could be made (only one bio is available in ->bio_split
> > mempool).
> >
> > This fix has been verified to still fix the loss of performance, due
> > to excess splitting, that commit 120c9257f5f1 provided.
> >
> > Fixes: 120c9257f5f1 ("Revert "dm: always call blk_queue_split() in dm_process_bio()"")
> > Cc: stable@vger.kernel.org # 5.0+, requires custom backport due to 5.9 changes
> > Reported-by: Ming Lei <ming.lei@redhat.com>
> > Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>
> What is the git id of this patch in Linus's tree?
I dug it up:
ee1dfad5325f ("dm: fix bio splitting and its bio completion order for regular IO")
next prev parent reply other threads:[~2020-09-28 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 13:56 FAILED: patch "[PATCH] dm: fix bio splitting and its bio completion order for" failed to apply to 5.4-stable tree gregkh
2020-09-28 15:29 ` [PATCH 5.4, 5.8] dm: fix bio splitting and its bio completion order for regular IO Mike Snitzer
2020-09-28 17:31 ` Greg KH
2020-09-28 17:52 ` Greg KH [this message]
2020-09-28 18:03 ` Mike Snitzer
2020-09-28 18:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928175229.GA2202997@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox