From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
linux-spi@vger.kernel.org
Subject: [PATCH AUTOSEL 5.8 24/29] spi: fsl-espi: Only process interrupts for expected events
Date: Mon, 28 Sep 2020 21:30:21 -0400 [thread overview]
Message-ID: <20200929013027.2406344-24-sashal@kernel.org> (raw)
In-Reply-To: <20200929013027.2406344-1-sashal@kernel.org>
From: Chris Packham <chris.packham@alliedtelesis.co.nz>
[ Upstream commit b867eef4cf548cd9541225aadcdcee644669b9e1 ]
The SPIE register contains counts for the TX FIFO so any time the irq
handler was invoked we would attempt to process the RX/TX fifos. Use the
SPIM value to mask the events so that we only process interrupts that
were expected.
This was a latent issue exposed by commit 3282a3da25bd ("powerpc/64:
Implement soft interrupt replay in C").
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Link: https://lore.kernel.org/r/20200904002812.7300-1-chris.packham@alliedtelesis.co.nz
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/spi/spi-fsl-espi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c
index e60581283a247..6d148ab70b93e 100644
--- a/drivers/spi/spi-fsl-espi.c
+++ b/drivers/spi/spi-fsl-espi.c
@@ -564,13 +564,14 @@ static void fsl_espi_cpu_irq(struct fsl_espi *espi, u32 events)
static irqreturn_t fsl_espi_irq(s32 irq, void *context_data)
{
struct fsl_espi *espi = context_data;
- u32 events;
+ u32 events, mask;
spin_lock(&espi->lock);
/* Get interrupt events(tx/rx) */
events = fsl_espi_read_reg(espi, ESPI_SPIE);
- if (!events) {
+ mask = fsl_espi_read_reg(espi, ESPI_SPIM);
+ if (!(events & mask)) {
spin_unlock(&espi->lock);
return IRQ_NONE;
}
--
2.25.1
next prev parent reply other threads:[~2020-09-29 1:35 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 1:29 [PATCH AUTOSEL 5.8 01/29] clocksource/drivers/timer-gx6605s: Fixup counter reload Sasha Levin
2020-09-29 1:29 ` [PATCH AUTOSEL 5.8 02/29] vboxsf: Fix the check for the old binary mount-arguments struct Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 03/29] mt76: mt7915: use ieee80211_free_txskb to free tx skbs Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 04/29] libbpf: Remove arch-specific include path in Makefile Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 05/29] drivers/net/wan/hdlc_fr: Add needed_headroom for PVC devices Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 06/29] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver" Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 07/29] drm/sun4i: mixer: Extend regmap max_register Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 08/29] net: dsa: microchip: look for phy-mode in port nodes Sasha Levin
2020-09-29 5:56 ` Helmut Grohne
2020-10-04 12:46 ` Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 09/29] hv_netvsc: Cache the current data path to avoid duplicate call and message Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 10/29] net: dec: de2104x: Increase receive ring size for Tulip Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 11/29] rndis_host: increase sleep time in the query-response loop Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 12/29] nvme-pci: disable the write zeros command for Intel 600P/P3100 Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 13/29] nvme-core: get/put ctrl and transport module in nvme_dev_open/release() Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 14/29] regmap: debugfs: Fix handling of name string for debugfs init delays Sasha Levin
2020-09-29 8:33 ` Charles Keepax
2020-10-04 12:54 ` Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 15/29] fuse: fix the ->direct_IO() treatment of iov_iter Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 16/29] drivers/net/wan/lapbether: Make skb->protocol consistent with the header Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 17/29] drivers/net/wan/hdlc: Set skb->protocol before transmitting Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 18/29] mac80211: Fix radiotap header channel flag for 6GHz band Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 19/29] mac80211: do not allow bigger VHT MPDUs than the hardware supports Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 20/29] tracing: Make the space reserved for the pid wider Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 21/29] tools/io_uring: fix compile breakage Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 22/29] io_uring: mark statx/files_update/epoll_ctl as non-SQPOLL Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 23/29] cpuidle: psci: Fix suspicious RCU usage Sasha Levin
2020-09-29 1:30 ` Sasha Levin [this message]
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 25/29] net: dsa: felix: fix some key offsets for IP4_TCP_UDP VCAP IS2 entries Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 26/29] nvme-pci: fix NULL req in completion handler Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 27/29] nvme-fc: fail new connections to a deleted host or remote port Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 28/29] spi: fsl-dspi: fix use-after-free in remove path Sasha Levin
2020-09-29 6:22 ` Sascha Hauer
2020-10-04 12:58 ` Sasha Levin
2020-09-29 1:30 ` [PATCH AUTOSEL 5.8 29/29] scripts/kallsyms: skip ppc compiler stub *.long_branch.* / *.plt_branch.* Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929013027.2406344-24-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=broonie@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox