From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org, Heiko Stuebner <heiko@sntech.de>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Sandy Huang <hjc@rock-chips.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
Date: Tue, 29 Sep 2020 09:17:54 +0200 [thread overview]
Message-ID: <20200929071754.GA736868@ravnborg.org> (raw)
In-Reply-To: <83650213-3b09-aea0-4485-cd20de1d9548@suse.de>
On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote:
> Hi Sam
>
> Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
> > Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> > introduced the following build error:
> >
> > rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
> > 304 | .vm_ops = &drm_gem_cma_vm_ops,
> > | ^~~~~~~~~~~~~~~~~~
> > | drm_gem_mmap_obj
> >
> > Fixed by adding missing include file.
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>
> Didn't you review exactly this change yesterday? Anyway, you should add
Yep.
>
> Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
>
> and
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> It might happen that I land my patch first, depending on the urgency of
> the issue.
I expect you to land the patch you made asap so we can have the build
fixed again.
Sam
next prev parent reply other threads:[~2020-09-29 7:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 21:55 [PATCH v1 0/2] drm/rockchip: fix build + warning Sam Ravnborg
2020-09-25 21:55 ` [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops Sam Ravnborg
2020-09-29 6:53 ` Thomas Zimmermann
2020-09-29 7:17 ` Sam Ravnborg [this message]
2020-09-29 7:47 ` Thomas Zimmermann
2020-09-25 21:55 ` [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume Sam Ravnborg
2020-09-28 14:42 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929071754.GA736868@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox