From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E9FC4346E for ; Tue, 29 Sep 2020 07:23:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBED62083B for ; Tue, 29 Sep 2020 07:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725787AbgI2HXr (ORCPT ); Tue, 29 Sep 2020 03:23:47 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:56528 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbgI2HXr (ORCPT ); Tue, 29 Sep 2020 03:23:47 -0400 X-Greylist: delayed 347 seconds by postgrey-1.27 at vger.kernel.org; Tue, 29 Sep 2020 03:23:46 EDT Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 08D27804E5; Tue, 29 Sep 2020 09:17:55 +0200 (CEST) Date: Tue, 29 Sep 2020 09:17:54 +0200 From: Sam Ravnborg To: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org, Heiko Stuebner , Enric Balletbo i Serra , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Sandy Huang , stable@vger.kernel.org Subject: Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops Message-ID: <20200929071754.GA736868@ravnborg.org> References: <20200925215524.2899527-1-sam@ravnborg.org> <20200925215524.2899527-2-sam@ravnborg.org> <83650213-3b09-aea0-4485-cd20de1d9548@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <83650213-3b09-aea0-4485-cd20de1d9548@suse.de> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=A5ZCwZeG c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=7gkXJVJtAAAA:8 a=nVws210Im4UeU8Tq7v4A:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Sep 29, 2020 at 08:53:06AM +0200, Thomas Zimmermann wrote: > Hi Sam > > Am 25.09.20 um 23:55 schrieb Sam Ravnborg: > > Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs") > > introduced the following build error: > > > > rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here > > 304 | .vm_ops = &drm_gem_cma_vm_ops, > > | ^~~~~~~~~~~~~~~~~~ > > | drm_gem_mmap_obj > > > > Fixed by adding missing include file. > > > > Signed-off-by: Sam Ravnborg > > Didn't you review exactly this change yesterday? Anyway, you should add Yep. > > Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs") > > and > > Reviewed-by: Thomas Zimmermann > > It might happen that I land my patch first, depending on the urgency of > the issue. I expect you to land the patch you made asap so we can have the build fixed again. Sam