From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0AFDC433E7 for ; Mon, 12 Oct 2020 13:53:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D4662074F for ; Mon, 12 Oct 2020 13:53:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602510808; bh=sDVmi4QymjyKKOUibsw5V7hvYNGAgBABqBFagZtpbNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xB4MpBBdbqpAssv05YUi5noqrhe+fppFOqqhkljaPKtL4qFOYgybDLwG2AhqCYXhL s6Cx+vyP9fL7jjiXIbGqZZfHjKDcO+ad/4pS9DJC/RLQU6VwXt2wrZbOWMNH7XMO9K zlcQGadxkjYQeWBOBaENqqPOw9+br6amOvQ1L7M8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390161AbgJLNxQ (ORCPT ); Mon, 12 Oct 2020 09:53:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:54096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731549AbgJLNrG (ORCPT ); Mon, 12 Oct 2020 09:47:06 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B676021D7F; Mon, 12 Oct 2020 13:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602510399; bh=sDVmi4QymjyKKOUibsw5V7hvYNGAgBABqBFagZtpbNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wnAIlPBdYWzlpHSlIX2OBfuCn+owVKDHmF7DYeXAxjOji4Dxt5hDONoJrdx9qYkAV CErYdSvFAzYesWd0dXu0iYzfjzyKUhVMd3dhVDeTAIz02A4KZAAAijgW0L9LymDz14 3S/VUAMYESSRSIwNMaUT+amTTIgb0OgeztzVZ/AY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hariprasad Kelam , Geetha sowjanya , Sunil Goutham , "David S. Miller" , Sasha Levin Subject: [PATCH 5.8 081/124] octeontx2-pf: Fix the device state on error Date: Mon, 12 Oct 2020 15:31:25 +0200 Message-Id: <20201012133150.781562055@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201012133146.834528783@linuxfoundation.org> References: <20201012133146.834528783@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Hariprasad Kelam [ Upstream commit 1ea0166da0509e987caa42c30a6a71f2c6ca1875 ] Currently in otx2_open on failure of nix_lf_start transmit queues are not stopped which are already started in link_event. Since the tx queues are not stopped network stack still try's to send the packets leading to driver crash while access the device resources. Fixes: 50fe6c02e ("octeontx2-pf: Register and handle link notifications") Signed-off-by: Hariprasad Kelam Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c index 75a8c407e815c..5d620a39ea802 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c @@ -1560,10 +1560,13 @@ int otx2_open(struct net_device *netdev) err = otx2_rxtx_enable(pf, true); if (err) - goto err_free_cints; + goto err_tx_stop_queues; return 0; +err_tx_stop_queues: + netif_tx_stop_all_queues(netdev); + netif_carrier_off(netdev); err_free_cints: otx2_free_cints(pf, qidx); vec = pci_irq_vector(pf->pdev, -- 2.25.1