From: Greg KH <gregkh@linuxfoundation.org>
To: Ben Chuang <benchuanggli@gmail.com>
Cc: sashal@kernel.org, stable@vger.kernel.org,
Ben Chuang <ben.chuang@genesyslogic.com.tw>,
greg.tu@genesyslogic.com.tw, seanhy.chen@genesyslogic.com.tw,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: sdhci-pci-gli: Set SDR104's clock to 205MHz and enable SSC for GL975x
Date: Tue, 13 Oct 2020 15:48:49 +0200 [thread overview]
Message-ID: <20201013134849.GA1968052@kroah.com> (raw)
In-Reply-To: <CACT4zj-ShpspM0PNA_Q4fkEAubiTfp_rxcZ6FkQgcKoYx7WaNA@mail.gmail.com>
On Tue, Oct 13, 2020 at 07:11:13PM +0800, Ben Chuang wrote:
> On Tue, Oct 13, 2020 at 4:57 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Oct 13, 2020 at 04:33:38PM +0800, Ben Chuang wrote:
> > > On Tue, Oct 13, 2020 at 4:00 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Tue, Oct 13, 2020 at 03:46:00PM +0800, Ben Chuang wrote:
> > > > > From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> > > > >
> > > > > commit 786d33c887e15061ff95942db68fe5c6ca98e5fc upstream.
> > > > >
> > > > > Set SDR104's clock to 205MHz and enable SSC for GL9750 and GL9755
> > > > >
> > > > > Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> > > > > Link: https://lore.kernel.org/r/20200717033350.13006-1-benchuanggli@gmail.com
> > > > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > > > Cc: <stable@vger.kernel.org> # 5.4.x
> > > > > ---
> > > > > Hi Greg and Sasha,
> > > > >
> > > > > The patch is to improve the EMI of the hardware.
> > > > > So it should be also required for some hardware devices using the v5.4.
> > > > > Please tell me if have other questions.
> > > >
> > > > This looks like a "add support for new hardware" type of patch, right?
> > >
> > > No, this is for a mass production hardware.
> >
> > That does not make sense, sorry.
> >
> > Is this a bug that is being fixed, did the hardware work properly before
> > 5.4 and now it does not? Or has it never worked properly and 5.9 is the
> > first kernel that it now works on?
>
> It seems there is misunderstanding regarding “hardware” means.
> I originally thought that the "hardware" refers to GL975x chips.
>
> This Genesys patch is to fix the EMI problem for GL975x controller on a system.
Did it work on the 4.19 kernel? Another older kernel? Or is 5.9 the
first kernel release where it works?
In other words, is this fixing a regression, or just enabling hardware
support for something that has never worked before for this hardware?
> There is a new Linux-based system now in development stage build in
> the GL975x controller
> encounter the EMI problem due to the Kernel 5.4 do not support Genesys
> patch for EMI.
> Hence we would like to add the patch to Kernel 5.4.
Why not just use 5.9 for this system?
thanks,
greg k-h
next prev parent reply other threads:[~2020-10-13 13:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 7:46 [PATCH] mmc: sdhci-pci-gli: Set SDR104's clock to 205MHz and enable SSC for GL975x Ben Chuang
2020-10-13 8:01 ` Greg KH
2020-10-13 8:33 ` Ben Chuang
2020-10-13 8:58 ` Greg KH
2020-10-13 11:11 ` Ben Chuang
2020-10-13 13:48 ` Greg KH [this message]
2020-10-14 8:00 ` Ben Chuang
2020-10-14 8:11 ` Greg KH
2020-10-14 10:42 ` Ben Chuang
2020-10-14 11:37 ` Greg KH
2020-10-15 1:17 ` Ben Chuang
2020-10-21 3:27 ` Ben Chuang
2020-10-21 5:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013134849.GA1968052@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ben.chuang@genesyslogic.com.tw \
--cc=benchuanggli@gmail.com \
--cc=greg.tu@genesyslogic.com.tw \
--cc=sashal@kernel.org \
--cc=seanhy.chen@genesyslogic.com.tw \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).