From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A197DC433DF for ; Tue, 13 Oct 2020 13:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 499C824765 for ; Tue, 13 Oct 2020 13:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602596895; bh=Vc6zC/HFdE19SlF19xRJgWbFPBOASS38GINE+YRuMAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1mZOSYlB47iPL8fDhIbGm1BEK39k5ZBrrQB4tcEfkxW8OVW7pGKKxsu2QhnH/8KCq hbE9W0VUrpkxt3ukk+obBlWQKTjkxUgQEs9wDLtKnH4L6jKmYPlL3X0HsYSKA6vGno UUr67p0LE3heuS9/7bi/w/gJP7UfCMJE5NseU6g8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728784AbgJMNsP (ORCPT ); Tue, 13 Oct 2020 09:48:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:45506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727292AbgJMNsN (ORCPT ); Tue, 13 Oct 2020 09:48:13 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 107B52474E; Tue, 13 Oct 2020 13:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602596892; bh=Vc6zC/HFdE19SlF19xRJgWbFPBOASS38GINE+YRuMAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zy5dTpuYnxWR1H2EvH7+RSdLWBYRYICo8XB++ifx6UX5S5rDC+PvjowmBHoILOqol n78kYHGEPp58i875ZGy8+RV2Huyzy37Dewfm/C95wsETEeD4Zu9wbqyPwrADWLYY4U 7IPhPk7zAtOpxW40pFg+DOwgPkCas65/5Y95/biQ= Date: Tue, 13 Oct 2020 15:48:49 +0200 From: Greg KH To: Ben Chuang Cc: sashal@kernel.org, stable@vger.kernel.org, Ben Chuang , greg.tu@genesyslogic.com.tw, seanhy.chen@genesyslogic.com.tw, Ulf Hansson Subject: Re: [PATCH] mmc: sdhci-pci-gli: Set SDR104's clock to 205MHz and enable SSC for GL975x Message-ID: <20201013134849.GA1968052@kroah.com> References: <20201013074600.9784-1-benchuanggli@gmail.com> <20201013080105.GA1681211@kroah.com> <20201013085806.GB1681211@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Oct 13, 2020 at 07:11:13PM +0800, Ben Chuang wrote: > On Tue, Oct 13, 2020 at 4:57 PM Greg KH wrote: > > > > On Tue, Oct 13, 2020 at 04:33:38PM +0800, Ben Chuang wrote: > > > On Tue, Oct 13, 2020 at 4:00 PM Greg KH wrote: > > > > > > > > On Tue, Oct 13, 2020 at 03:46:00PM +0800, Ben Chuang wrote: > > > > > From: Ben Chuang > > > > > > > > > > commit 786d33c887e15061ff95942db68fe5c6ca98e5fc upstream. > > > > > > > > > > Set SDR104's clock to 205MHz and enable SSC for GL9750 and GL9755 > > > > > > > > > > Signed-off-by: Ben Chuang > > > > > Link: https://lore.kernel.org/r/20200717033350.13006-1-benchuanggli@gmail.com > > > > > Signed-off-by: Ulf Hansson > > > > > Cc: # 5.4.x > > > > > --- > > > > > Hi Greg and Sasha, > > > > > > > > > > The patch is to improve the EMI of the hardware. > > > > > So it should be also required for some hardware devices using the v5.4. > > > > > Please tell me if have other questions. > > > > > > > > This looks like a "add support for new hardware" type of patch, right? > > > > > > No, this is for a mass production hardware. > > > > That does not make sense, sorry. > > > > Is this a bug that is being fixed, did the hardware work properly before > > 5.4 and now it does not? Or has it never worked properly and 5.9 is the > > first kernel that it now works on? > > It seems there is misunderstanding regarding “hardware” means. > I originally thought that the "hardware" refers to GL975x chips. > > This Genesys patch is to fix the EMI problem for GL975x controller on a system. Did it work on the 4.19 kernel? Another older kernel? Or is 5.9 the first kernel release where it works? In other words, is this fixing a regression, or just enabling hardware support for something that has never worked before for this hardware? > There is a new Linux-based system now in development stage build in > the GL975x controller > encounter the EMI problem due to the Kernel 5.4 do not support Genesys > patch for EMI. > Hence we would like to add the patch to Kernel 5.4. Why not just use 5.9 for this system? thanks, greg k-h