From: Greg KH <gregkh@linuxfoundation.org>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>
Cc: Alex Deucher <alexdeucher@gmail.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] Revert "drm/amdgpu: Fix NULL dereference in dpm sysfs handlers"
Date: Fri, 16 Oct 2020 09:43:09 +0200 [thread overview]
Message-ID: <20201016074309.GA852856@kroah.com> (raw)
In-Reply-To: <MN2PR12MB44881689BB508017AE3174E8F7020@MN2PR12MB4488.namprd12.prod.outlook.com>
On Thu, Oct 15, 2020 at 02:11:17PM +0000, Deucher, Alexander wrote:
> [AMD Public Use]
>
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Thursday, October 15, 2020 10:06 AM
> > To: Deucher, Alexander <Alexander.Deucher@amd.com>
> > Cc: Alex Deucher <alexdeucher@gmail.com>; stable@vger.kernel.org
> > Subject: Re: [PATCH] Revert "drm/amdgpu: Fix NULL dereference in dpm
> > sysfs handlers"
> >
> > On Thu, Oct 15, 2020 at 01:18:34PM +0000, Deucher, Alexander wrote:
> > > [AMD Public Use]
> > >
> > > > -----Original Message-----
> > > > From: Greg KH <gregkh@linuxfoundation.org>
> > > > Sent: Thursday, October 15, 2020 1:15 AM
> > > > To: Alex Deucher <alexdeucher@gmail.com>
> > > > Cc: stable@vger.kernel.org; Deucher, Alexander
> > > > <Alexander.Deucher@amd.com>
> > > > Subject: Re: [PATCH] Revert "drm/amdgpu: Fix NULL dereference in dpm
> > > > sysfs handlers"
> > > >
> > > > On Wed, Oct 14, 2020 at 04:28:36PM -0400, Alex Deucher wrote:
> > > > > This regressed some working configurations so revert it. Will fix
> > > > > this properly for 5.9 and backport then.
> > > >
> > > > What do you mean "backport then"?
> > > >
> > > > >
> > > > > This reverts commit 38e0c89a19fd13f28d2b4721035160a3e66e270b.
> > > > >
> > > > > This needs to be applied to 5.9 as well. -next (5.10) has this
> > > > > already, but 5.9 missed it.
> > > >
> > > > What is the real fix for this? Is it in Linus's tree and I can just
> > > > backport that fix?
> > > >
> > >
> > > This is no real fix. The revert is the fix. Sorry, I should have clarified that.
> >
> > Is it also reverted in Linus's tree? If so, what's that commit id?
> >
> > If not, shouldn't it be?
>
> It is reverted in Linus' tree. I cherry-picked the revert from Linus' tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=87004abfbc27261edd15716515d89ab42198b405
Ok, I've queued that one up now, can you also send me versions of this
for the older kernel trees that need it (I think 4.19.y and 5.4.y).
thanks,
greg k-h
prev parent reply other threads:[~2020-10-16 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 20:28 [PATCH] Revert "drm/amdgpu: Fix NULL dereference in dpm sysfs handlers" Alex Deucher
2020-10-15 5:14 ` Greg KH
2020-10-15 13:18 ` Deucher, Alexander
2020-10-15 14:06 ` Greg KH
2020-10-15 14:11 ` Deucher, Alexander
2020-10-16 7:43 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016074309.GA852856@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Alexander.Deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox