From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B38C2D0A3 for ; Mon, 26 Oct 2020 14:23:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54D5C2075B for ; Mon, 26 Oct 2020 14:23:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603722211; bh=3cRs8+aFIHwhDrhEhE6hbibf8pvjg4zxaQgkKiudhoE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pu3WOcA9hrVsTgs95Zejov599ukgkp38jVgZyKOGtI4bZ5LPQ15dYz+MO0sW1GsMT czo2dQj1+mww9/GT9NQo28a9TNyWJZCo6rLKCIwhEPHjZeTFhqnk5X5dWQ3p494N6P x6yrKoTENEOE6ju83wRsl9xTtG/5C23o022o9Emk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1780814AbgJZOXa (ORCPT ); Mon, 26 Oct 2020 10:23:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:57524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1780757AbgJZOXa (ORCPT ); Mon, 26 Oct 2020 10:23:30 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CA692075B; Mon, 26 Oct 2020 14:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603722210; bh=3cRs8+aFIHwhDrhEhE6hbibf8pvjg4zxaQgkKiudhoE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=chUkWrnl/1VgEMLV6DbOuJp3uB9mSpQt3naktmSInhvKrLW4GZNsUUsC114vYhmpL e4an/HslLVxyn7aJDoppaFVhNlh5grR8TrjantzQ90J6SDWnjnFzVjm8zy1cGFO95a 5Tdbl0fRY2wAsiL71zXOwq4qX8kEbQcR5EiwsxNI= Date: Mon, 26 Oct 2020 10:23:29 -0400 From: Sasha Levin To: Matthieu Baerts Cc: stable-commits@vger.kernel.org, stable Subject: Re: Patch "selftests: mptcp: depends on built-in IPv6" has been added to the 5.9-stable tree Message-ID: <20201026142329.GJ4060117@sasha-vm> References: <20201026051850.8F51D206A1@mail.kernel.org> <1de2bf78-4b47-21b0-9d56-3c8063cdf4bb@tessares.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1de2bf78-4b47-21b0-9d56-3c8063cdf4bb@tessares.net> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Oct 26, 2020 at 09:20:47AM +0100, Matthieu Baerts wrote: >Hi Sasha, > >On 26/10/2020 06:18, Sasha Levin wrote: >>This is a note to let you know that I've just added the patch titled >> >> selftests: mptcp: depends on built-in IPv6 > >Thank you for backporting this patch. > >(...) > >> Fixes: 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it") > >This patch is not really needed because AFAICS this commit here above >has not been backported to v5.9. It is only in v5.10-rc1. > >(...) > >>diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config >>index 8df5cb8f71ff9..741a1c4f4ae8f 100644 >>--- a/tools/testing/selftests/net/mptcp/config >>+++ b/tools/testing/selftests/net/mptcp/config >>@@ -1,4 +1,5 @@ >> CONFIG_MPTCP=y >>+CONFIG_IPV6=y >> CONFIG_MPTCP_IPV6=y > >But you can also keep this patch, it doesn't hurt: without this commit >010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of >selecting it"), CONFIG_MPTCP_IPV6=y selects CONFIG_IPV6=y. In other >words, adding "CONFIG_IPV6=y" here in the selftests config is >redundant if you don't have this commit 010b430d5df5 but not wrong. > >Note that if you also want to backport this commit 010b430d5df5 >("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it"), >you will need commit 0ed37ac586c0 ("mptcp: depends on IPV6 but not as >a module") as well. I'll drop the selftests fix then, thanks for the heads-up! -- Thanks, Sasha