From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07446C4741F for ; Fri, 30 Oct 2020 17:47:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFEED2151B for ; Fri, 30 Oct 2020 17:47:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727099AbgJ3Rrk convert rfc822-to-8bit (ORCPT ); Fri, 30 Oct 2020 13:47:40 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:44405 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725844AbgJ3Rrk (ORCPT ); Fri, 30 Oct 2020 13:47:40 -0400 X-Greylist: delayed 1222 seconds by postgrey-1.27 at vger.kernel.org; Fri, 30 Oct 2020 13:47:39 EDT X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B88B1C000A; Fri, 30 Oct 2020 17:47:37 +0000 (UTC) Date: Fri, 30 Oct 2020 18:47:36 +0100 From: Miquel Raynal To: Joakim Tjernlund Cc: "linux-mtd @ lists . infradead . org" , stable@vger.kernel.org Subject: Re: [PATCH] mtd: cfi_cmdset_0002: Use status register where possible Message-ID: <20201030184736.4ec434f5@xps13> In-Reply-To: <20201022154506.17639-1-joakim.tjernlund@infinera.com> References: <20201022154506.17639-1-joakim.tjernlund@infinera.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Joakim, Please Cc the MTD maintainers, not only the list (get_maintainers.pl). Joakim Tjernlund wrote on Thu, 22 Oct 2020 17:45:06 +0200: > Commit "mtd: cfi_cmdset_0002: Add support for polling status register" > added support for polling the status rather than using DQ polling. > However, status register is used only when DQ polling is missing. > Lets use status register when available as it is superior to DQ polling. > I will let vignesh comment about the content (looks fine by me) but you will need a Fixes tag here. > Signed-off-by: Joakim Tjernlund > Cc: stable@vger.kernel.org > --- > drivers/mtd/chips/cfi_cmdset_0002.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c > index a1f3e1031c3d..ee9b322e63bb 100644 > --- a/drivers/mtd/chips/cfi_cmdset_0002.c > +++ b/drivers/mtd/chips/cfi_cmdset_0002.c > @@ -117,7 +117,7 @@ static struct mtd_chip_driver cfi_amdstd_chipdrv = { > static int cfi_use_status_reg(struct cfi_private *cfi) > { > struct cfi_pri_amdstd *extp = cfi->cmdset_priv; > - u8 poll_mask = CFI_POLL_STATUS_REG | CFI_POLL_DQ; > + u8 poll_mask = CFI_POLL_STATUS_REG; > > return extp->MinorVersion >= '5' && > (extp->SoftwareFeatures & poll_mask) == CFI_POLL_STATUS_REG; Thanks, Miquèl