From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79BBDC388F9 for ; Sat, 31 Oct 2020 10:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29DD722202 for ; Sat, 31 Oct 2020 10:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604140178; bh=b5dW76EIFokZI+6FzLfCv4T51iLrydrrJrULF4T46VI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mO+yPoi47YseGbTRyANCdhalaWq4M0nDvguixIzra070gSh+znFakIsr5H5n4QRcr gtYj3Oc494rqTML4IpYQ45c5ygwmpFPX9shdYP77pYSt7LMdIjdLz4MR4GazmVPX+B h6CLsDzt7ObAVBBsh4/tLadtcbZ3OeLyOyZsMMKw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbgJaK3h (ORCPT ); Sat, 31 Oct 2020 06:29:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:57638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726752AbgJaK3f (ORCPT ); Sat, 31 Oct 2020 06:29:35 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 805FA20885; Sat, 31 Oct 2020 10:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604140175; bh=b5dW76EIFokZI+6FzLfCv4T51iLrydrrJrULF4T46VI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SunlFEtnH6MidXcF2p8JxBTCbWNCNAaCSaM59tj5CeVMVEmn9dPqSgXAWUGig1q7T QX7G5WxguTjefZzfX2nvVgNc+2jEZ0O3MAvR8jHEjefOzxOBGNOkhd+KZgVDWzWAvx mc77LtD+LtPx6ghshdUkXehHaMGUpr5vfmWt8ZfE= Date: Sat, 31 Oct 2020 11:30:20 +0100 From: Greg KH To: Nick Desaulniers Cc: "# 3.4.x" , Sasha Levin , Nathan Chancellor , Manoj Gupta , Luis Lozano , Arnd Bergmann , clang-built-linux , Herbert Xu , Jian Cai Subject: Re: [PATCH] crypto: x86/crc32c - fix building with clang ias Message-ID: <20201031103020.GA961225@kroah.com> References: <20201030190245.92967-1-jiancai@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Oct 30, 2020 at 12:06:28PM -0700, Nick Desaulniers wrote: > + stable > > On Fri, Oct 30, 2020 at 12:04 PM Jian Cai wrote: > > > > From: Arnd Bergmann > > > > commit 44623b2818f4 ("crypto: x86/crc32c - fix building with clang ias") > > upstream > > > > The clang integrated assembler complains about movzxw: > > > > arch/x86/crypto/crc32c-pcl-intel-asm_64.S:173:2: error: invalid instruction mnemonic 'movzxw' > > > > It seems that movzwq is the mnemonic that it expects instead, > > and this is what objdump prints when disassembling the file. > > > > Fixes: 6a8ce1ef3940 ("crypto: crc32c - Optimize CRC32C calculation with PCLMULQDQ instruction") > > Signed-off-by: Arnd Bergmann > > Reviewed-by: Nathan Chancellor > > Signed-off-by: Herbert Xu > > [jc: Fixed conflicts due to lack of 34fdce6981b969] Nit, please spell out commit ids as the documentation asks you to. I've edited it and done that now... thanks, greg k-h