From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A29F6C2D0A3 for ; Tue, 3 Nov 2020 22:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6425321556 for ; Tue, 3 Nov 2020 22:04:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604441087; bh=YhoGuxyaChjXmW6WNgO1uKqYXWUP9+s3XpmLtgoDT58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=eRss8KTxnCXKd7nZXzr/co2eRGZ+qRm2cTsi2cFpGpxJ0txfbh7UiUu8LfglTd2tB xjEv3J9scF/CuXdA0QUct0pQ6ILG6mGeR0cTQ2KRWptjIvsZiMalSIEapysK4G8vnv 4IeXQ90h3UuLheaJfH+1PbrOSNkMwqWTK5VKRKCo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729403AbgKCWEl (ORCPT ); Tue, 3 Nov 2020 17:04:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:56970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729957AbgKCUnX (ORCPT ); Tue, 3 Nov 2020 15:43:23 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 740D0223AC; Tue, 3 Nov 2020 20:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436202; bh=YhoGuxyaChjXmW6WNgO1uKqYXWUP9+s3XpmLtgoDT58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n1Iukus4p6spojJ8CoRn60FjgtwFkbjqi4G22x2b5x0jxPOQoY3A0spK/DtMYxIeM IipNEY2JSzMplsIj9N6VWKH/o/7dPVHhMTO7DloDXqOWNOdHMoH+gkyyAIx9Qjrbgx QXmEvQycBoC6AtI35XyX+SeIagMXFvKCBrC3IEss= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Murphy , Tero Kristo , Stephen Boyd , Sasha Levin Subject: [PATCH 5.9 148/391] clk: ti: clockdomain: fix static checker warning Date: Tue, 3 Nov 2020 21:33:19 +0100 Message-Id: <20201103203356.818168760@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203348.153465465@linuxfoundation.org> References: <20201103203348.153465465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tero Kristo [ Upstream commit b7a7943fe291b983b104bcbd2f16e8e896f56590 ] Fix a memory leak induced by not calling clk_put after doing of_clk_get. Reported-by: Dan Murphy Signed-off-by: Tero Kristo Link: https://lore.kernel.org/r/20200907082600.454-3-t-kristo@ti.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/clockdomain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c index ee56306f79d5f..700b7f44f6716 100644 --- a/drivers/clk/ti/clockdomain.c +++ b/drivers/clk/ti/clockdomain.c @@ -148,10 +148,12 @@ static void __init of_ti_clockdomain_setup(struct device_node *node) if (!omap2_clk_is_hw_omap(clk_hw)) { pr_warn("can't setup clkdm for basic clk %s\n", __clk_get_name(clk)); + clk_put(clk); continue; } to_clk_hw_omap(clk_hw)->clkdm_name = clkdm_name; omap2_init_clk_clkdm(clk_hw); + clk_put(clk); } } -- 2.27.0