From: Sasha Levin <sashal@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: stable <stable@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linu Cherian <lcherian@marvell.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: Please consider reverting commit bb1860efc817 ("coresight: Make sysfs functional...") from v5.4.y
Date: Sun, 8 Nov 2020 08:29:22 -0500 [thread overview]
Message-ID: <20201108132922.GR2092@sasha-vm> (raw)
In-Reply-To: <5500643d-5813-d731-0181-bc57e6d33e5a@roeck-us.net>
On Sat, Nov 07, 2020 at 07:05:11PM -0800, Guenter Roeck wrote:
>Hi,
>
>I get the following build warning in v5.4.75.
>
>drivers/hwtracing/coresight/coresight-etm-perf.c: In function 'etm_setup_aux':
>drivers/hwtracing/coresight/coresight-etm-perf.c:226:37: warning:
> passing argument 1 of 'coresight_get_enabled_sink' makes pointer from integer without a cast
>
>Actually, the warning is fatal, since the call is
> sink = coresight_get_enabled_sink(true);
>However, the argument to coresight_get_enabled_sink() is now a pointer.
>The parameter change was introduced with commit 8fd52a21ab57
>("coresight: Make sysfs functional on topologies with per core sink").
>
>In the upstream kernel, the call is removed with commit bb1860efc817
>("coresight: etm: perf: Sink selection using sysfs is deprecated").
>That commit alone would, however, likely not solve the problem.
>It looks like at least two more commits would be needed.
>
>716f5652a131 coresight: etm: perf: Fix warning caused by etm_setup_aux failure
>8e264c52e1da coresight: core: Allow the coresight core driver to be built as a module
>39a7661dcf65 coresight: Fix uninitialised pointer bug in etm_setup_aux()
>
>Looking into the coresight code, I see several additional commits affecting
>the sysfs interface since v5.4. I have no idea what would actually be needed
>for stable code in v5.4.y, short of applying them all.
>
>With all this in mind, I would suggest to revert commit 8fd52a21ab57
>("coresight: Make sysfs functional on topologies with per core sink")
>from v5.4.y, especially since it is not marked as bug fix or for stable.
I'll revert it, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2020-11-08 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 3:05 Please consider reverting commit bb1860efc817 ("coresight: Make sysfs functional...") from v5.4.y Guenter Roeck
2020-11-08 13:29 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201108132922.GR2092@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lcherian@marvell.com \
--cc=linux@roeck-us.net \
--cc=mathieu.poirier@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox