public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: stable <stable@vger.kernel.org>
Subject: Re: [PATCH] fork: fix copy_process(CLONE_PARENT) race with the exiting ->real_parent
Date: Mon, 9 Nov 2020 12:44:22 +0100	[thread overview]
Message-ID: <20201109114421.GA30446@redhat.com> (raw)
In-Reply-To: <CAHk-=wgukcYn0xpqJ+Vda1Zw9wxPCxV0L_ZX6AmpgapT9Lp2mw@mail.gmail.com>

On 11/08, Linus Torvalds wrote:
>
> But it does look like a real data race, and the fix looks small and
> obvious enough that I think it's stable material.

Agreed, the patch looks fine for -stable. I don't think that
cgroup_can_fork() could ever use thread_group_leader() or anything
else which checks ->exit_code...

And I see that Greg has already sent the patches with the correct
modifications for the case when we need "clone_flags & CSIGNAL"
rather than args->exit_signal.

Thanks Greg,

Oleg.


      parent reply	other threads:[~2020-11-09 11:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201107064722.GA139215@arch-e3.localdomain>
     [not found] ` <CAHk-=whjyOuO-xwov7UWidBOkWyZv84TVA18hBb01V-hiML+yg@mail.gmail.com>
2020-11-08 19:56   ` [PATCH] fork: fix copy_process(CLONE_PARENT) race with the exiting ->real_parent Linus Torvalds
2020-11-09 10:20     ` Greg KH
2020-11-09 11:44     ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109114421.GA30446@redhat.com \
    --to=oleg@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox