From: Kamal Mostafa <kamal@canonical.com>
To: Sasha Levin <sashal@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Verbeiren <david.verbeiren@tessares.net>,
stable@vger.kernel.org
Subject: Re: [5.4.y] selftests/bpf build broken by "bpf: Zero-fill..."
Date: Mon, 7 Dec 2020 14:42:40 -0800 [thread overview]
Message-ID: <20201207224238.GA28646@ascalon> (raw)
In-Reply-To: <20201204182846.27110-1-kamal@canonical.com>
On Fri, Dec 04, 2020 at 10:28:46AM -0800, Kamal Mostafa wrote:
> Hi Sasha-
>
> This v5.4.78 commit breaks the tools/testing/selftests/bpf build:
>
> [linux-5.4.y] c602ad2b52dc bpf: Zero-fill re-used per-cpu map element
>
> Like this:
>
> prog_tests/map_init.c:5:10: fatal error: test_map_init.skel.h: No such file or directory
> 5 | #include "test_map_init.skel.h"
>
> Because tools/testing/selftests/bpf/Makefile in v5.4 does not have the
> "skeleton header generation" stuff (circa v5.6).
>
> Reverting c602ad2b52dc from linux-5.4.y fixes it.
Another option would be to just drop the selftest from linux-5.4.y,
but keep the beneficial change to kernel/bpf/hashtab.c.
(We're leaning towards that approach for Ubuntu).
-Kamal
next prev parent reply other threads:[~2020-12-07 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 18:28 [5.4.y] selftests/bpf build broken by "bpf: Zero-fill..." Kamal Mostafa
2020-12-07 22:42 ` Kamal Mostafa [this message]
2020-12-08 7:49 ` David Verbeiren
2020-12-08 14:53 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207224238.GA28646@ascalon \
--to=kamal@canonical.com \
--cc=david.verbeiren@tessares.net \
--cc=gregkh@linuxfoundation.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).