* [5.4.y] selftests/bpf build broken by "bpf: Zero-fill..."
@ 2020-12-04 18:28 Kamal Mostafa
2020-12-07 22:42 ` Kamal Mostafa
0 siblings, 1 reply; 4+ messages in thread
From: Kamal Mostafa @ 2020-12-04 18:28 UTC (permalink / raw)
To: Sasha Levin; +Cc: Greg Kroah-Hartman, David Verbeiren, stable
Hi Sasha-
This v5.4.78 commit breaks the tools/testing/selftests/bpf build:
[linux-5.4.y] c602ad2b52dc bpf: Zero-fill re-used per-cpu map element
Like this:
prog_tests/map_init.c:5:10: fatal error: test_map_init.skel.h: No such file or directory
5 | #include "test_map_init.skel.h"
Because tools/testing/selftests/bpf/Makefile in v5.4 does not have the
"skeleton header generation" stuff (circa v5.6).
Reverting c602ad2b52dc from linux-5.4.y fixes it.
-Kamal
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [5.4.y] selftests/bpf build broken by "bpf: Zero-fill..."
2020-12-04 18:28 [5.4.y] selftests/bpf build broken by "bpf: Zero-fill..." Kamal Mostafa
@ 2020-12-07 22:42 ` Kamal Mostafa
2020-12-08 7:49 ` David Verbeiren
2020-12-08 14:53 ` Sasha Levin
0 siblings, 2 replies; 4+ messages in thread
From: Kamal Mostafa @ 2020-12-07 22:42 UTC (permalink / raw)
To: Sasha Levin; +Cc: Greg Kroah-Hartman, David Verbeiren, stable
On Fri, Dec 04, 2020 at 10:28:46AM -0800, Kamal Mostafa wrote:
> Hi Sasha-
>
> This v5.4.78 commit breaks the tools/testing/selftests/bpf build:
>
> [linux-5.4.y] c602ad2b52dc bpf: Zero-fill re-used per-cpu map element
>
> Like this:
>
> prog_tests/map_init.c:5:10: fatal error: test_map_init.skel.h: No such file or directory
> 5 | #include "test_map_init.skel.h"
>
> Because tools/testing/selftests/bpf/Makefile in v5.4 does not have the
> "skeleton header generation" stuff (circa v5.6).
>
> Reverting c602ad2b52dc from linux-5.4.y fixes it.
Another option would be to just drop the selftest from linux-5.4.y,
but keep the beneficial change to kernel/bpf/hashtab.c.
(We're leaning towards that approach for Ubuntu).
-Kamal
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [5.4.y] selftests/bpf build broken by "bpf: Zero-fill..."
2020-12-07 22:42 ` Kamal Mostafa
@ 2020-12-08 7:49 ` David Verbeiren
2020-12-08 14:53 ` Sasha Levin
1 sibling, 0 replies; 4+ messages in thread
From: David Verbeiren @ 2020-12-08 7:49 UTC (permalink / raw)
To: Kamal Mostafa, Sasha Levin; +Cc: Greg Kroah-Hartman, stable
Hi Kamal, Sasha,
On Mon, Dec 7, 2020 at 11:42 PM Kamal Mostafa <kamal@canonical.com> wrote:
>
> On Fri, Dec 04, 2020 at 10:28:46AM -0800, Kamal Mostafa wrote:
> > Hi Sasha-
> >
> > This v5.4.78 commit breaks the tools/testing/selftests/bpf build:
> >
> > [linux-5.4.y] c602ad2b52dc bpf: Zero-fill re-used per-cpu map element
> >
> > Like this:
> >
> > prog_tests/map_init.c:5:10: fatal error: test_map_init.skel.h: No such file or directory
> > 5 | #include "test_map_init.skel.h"
> >
> > Because tools/testing/selftests/bpf/Makefile in v5.4 does not have the
> > "skeleton header generation" stuff (circa v5.6).
> >
> > Reverting c602ad2b52dc from linux-5.4.y fixes it.
>
> Another option would be to just drop the selftest from linux-5.4.y,
> but keep the beneficial change to kernel/bpf/hashtab.c.
>
> (We're leaning towards that approach for Ubuntu).
>
> -Kamal
An alternative could be to use the initial version of the selftest I had
proposed before learning about the skeleton approach.
You can find it here:
https://lore.kernel.org/bpf/20201029111730.6881-1-david.verbeiren@tessares.net/
I also think it would be good to keep the fix of course.
-David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [5.4.y] selftests/bpf build broken by "bpf: Zero-fill..."
2020-12-07 22:42 ` Kamal Mostafa
2020-12-08 7:49 ` David Verbeiren
@ 2020-12-08 14:53 ` Sasha Levin
1 sibling, 0 replies; 4+ messages in thread
From: Sasha Levin @ 2020-12-08 14:53 UTC (permalink / raw)
To: Kamal Mostafa; +Cc: Greg Kroah-Hartman, David Verbeiren, stable
On Mon, Dec 07, 2020 at 02:42:40PM -0800, Kamal Mostafa wrote:
>On Fri, Dec 04, 2020 at 10:28:46AM -0800, Kamal Mostafa wrote:
>> Hi Sasha-
>>
>> This v5.4.78 commit breaks the tools/testing/selftests/bpf build:
>>
>> [linux-5.4.y] c602ad2b52dc bpf: Zero-fill re-used per-cpu map element
>>
>> Like this:
>>
>> prog_tests/map_init.c:5:10: fatal error: test_map_init.skel.h: No such file or directory
>> 5 | #include "test_map_init.skel.h"
>>
>> Because tools/testing/selftests/bpf/Makefile in v5.4 does not have the
>> "skeleton header generation" stuff (circa v5.6).
>>
>> Reverting c602ad2b52dc from linux-5.4.y fixes it.
>
>Another option would be to just drop the selftest from linux-5.4.y,
>but keep the beneficial change to kernel/bpf/hashtab.c.
>
>(We're leaning towards that approach for Ubuntu).
That's what I did, thanks!
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-08 14:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-04 18:28 [5.4.y] selftests/bpf build broken by "bpf: Zero-fill..." Kamal Mostafa
2020-12-07 22:42 ` Kamal Mostafa
2020-12-08 7:49 ` David Verbeiren
2020-12-08 14:53 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).