From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52247C4332B for ; Wed, 30 Dec 2020 13:05:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CA532222A for ; Wed, 30 Dec 2020 13:05:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727322AbgL3NFF (ORCPT ); Wed, 30 Dec 2020 08:05:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:54242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727313AbgL3NFF (ORCPT ); Wed, 30 Dec 2020 08:05:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id CA64022482; Wed, 30 Dec 2020 13:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609333424; bh=wNn5OVPGzvJBRu9PKBApH/bCNsGShBsY94tzkQUFjUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YPtdTXYo2Y0THWx2KvpsLxnm9G24mlHfU1LW7HQ5nymVJx3yO6w9En+ppV+5Dyi/1 11EM60tfUfoKgxk8VxI31ylUXEkvGvGEFRSfSwiQe0pLDWbEFxPqZ/LdxD0B5M62eT /BWkbilReIywQUJqovEL15cDzwbkdFsqEK3iHKHW6/vzx4sp2FnP8GVmPLos4NQpYa dkE1fAeh3v5/41lhMb+p+rMqKSJ2sIrzWczYcxqsRFfH/UVoUoWH0OvG+ay7RnkG// diWrulX9KiKGWVh80ImraYeONM8SQzMaoVGGvDWkihhmCNO9YNPUjTV8ebrez77mFO UznNyRe+YYgqA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jeff Layton , Ilya Dryomov , Sasha Levin , ceph-devel@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 22/31] ceph: fix inode refcount leak when ceph_fill_inode on non-I_NEW inode fails Date: Wed, 30 Dec 2020 08:03:04 -0500 Message-Id: <20201230130314.3636961-22-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201230130314.3636961-1-sashal@kernel.org> References: <20201230130314.3636961-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jeff Layton [ Upstream commit 68cbb8056a4c24c6a38ad2b79e0a9764b235e8fa ] Signed-off-by: Jeff Layton Reviewed-by: Ilya Dryomov Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- fs/ceph/inode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index 526faf4778ce4..2462a9a84b956 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c @@ -1335,6 +1335,8 @@ int ceph_fill_trace(struct super_block *sb, struct ceph_mds_request *req) in, ceph_vinop(in)); if (in->i_state & I_NEW) discard_new_inode(in); + else + iput(in); goto done; } req->r_target_inode = in; -- 2.27.0