From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA4FC43331 for ; Thu, 7 Jan 2021 21:50:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3561323601 for ; Thu, 7 Jan 2021 21:50:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbhAGVuE (ORCPT ); Thu, 7 Jan 2021 16:50:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728051AbhAGVuD (ORCPT ); Thu, 7 Jan 2021 16:50:03 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F16DC0612F8 for ; Thu, 7 Jan 2021 13:49:23 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id g3so4513223plp.2 for ; Thu, 07 Jan 2021 13:49:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UTTy0WEJkMO0H2XumjV4y9QZB0fFUlY6gs6jKFnkPCs=; b=UgSAXxRcqgWDyOOtEvj9pyh3d/6tivv5BUeekYoFX9DpvpDSdK5CDcjpGyaOlBwMFK nSzen8slLXit0KPM6i7GnXZXh1ZjrfZKfAmcyvgw/vV5upbdruwILeYp8xm533pQMB2c 06qd9EgZCg7V3/GYV0mSRPxfP68Bxoj4ACUx0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UTTy0WEJkMO0H2XumjV4y9QZB0fFUlY6gs6jKFnkPCs=; b=njmcG2OXZ2vfC+oRLi/02jfXm7cxtkr8Gf/BJuxyOScUcaM/EcUV+QPVsyWRcOO1Ny zTLWyLhSlQolbJAsbmw3BMaiRwy4A8amOpVIE2QF544wBjEb0NbjALy21aZoK6CSdCZU orbl3+nz7sO0xwgVuKjM1f1ULhFShuaFQewgYBdkmWPWQDaKEtn/1NCBzXOXgGW66G2m T0v0QuUPerug7T9a1EVOMxl6TL/dyUlueQfqNWNiMenaXNvaq44ypybGgwatRLYesWs8 zBGd00V0WtROrb4C5iTo3PR3ckn8kcbiNiQlU5EOMDD9+ET0SwSix7usD5MKjsOZYToO 8Gkw== X-Gm-Message-State: AOAM530DSBQjbXiBIwZcmxV9e4md83E60FhygYSlWR5PYKuEMY2XyYXp LAPVnGMY+2fBRpOPeZ+CDEAy0A== X-Google-Smtp-Source: ABdhPJy7dqWS0KXS0gjfLEG7NjdBnTj4gGePU9Vljy5VYJdnOkLbAUkmKEts1AwkoPsJxhBNhTjIPQ== X-Received: by 2002:a17:90a:67ce:: with SMTP id g14mr473825pjm.33.1610056163137; Thu, 07 Jan 2021 13:49:23 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p187sm6618865pfp.60.2021.01.07.13.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 13:49:22 -0800 (PST) Date: Thu, 7 Jan 2021 13:49:21 -0800 From: Kees Cook To: Alexander Lobakin Cc: Thomas Bogendoerfer , Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Fangrui Song , Huacai Chen , Pei Huang , Jiaxun Yang , Sami Tolvanen , Ingo Molnar , Ralf Baechle , Corey Minyard , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, stable@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH v4 mips-next 5/7] MIPS: vmlinux.lds.S: explicitly declare .got table Message-ID: <202101071349.260EC64@keescook> References: <20210107123331.354075-1-alobakin@pm.me> <20210107132010.463129-1-alobakin@pm.me> <20210107132010.463129-2-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210107132010.463129-2-alobakin@pm.me> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Jan 07, 2021 at 01:20:49PM +0000, Alexander Lobakin wrote: > LLVM stack generates GOT table when building the kernel: > > ld.lld: warning: :(.got) is being placed in '.got' > > According to the debug assertions, it's not zero-sized and thus > can't be handled the same way as .rel.dyn (like it's done for x86). > Use the ARM/ARM64 path here and place it at the end of .text section. > > Reported-by: Nathan Chancellor > Signed-off-by: Alexander Lobakin Reviewed-by: Kees Cook -- Kees Cook