From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Jakub Kicinski <kubakici@wp.pl>,
Kalle Valo <kvalo@codeaurora.org>
Subject: [PATCH 5.4 26/61] mt7601u: fix rx buffer refcounting
Date: Tue, 2 Feb 2021 14:38:04 +0100 [thread overview]
Message-ID: <20210202132947.567675654@linuxfoundation.org> (raw)
In-Reply-To: <20210202132946.480479453@linuxfoundation.org>
From: Lorenzo Bianconi <lorenzo@kernel.org>
commit d24c790577ef01bfa01da2b131313a38c843a634 upstream.
Fix the following crash due to erroneous page refcounting:
[ 32.445919] BUG: Bad page state in process swapper/1 pfn:11f65a
[ 32.447409] page:00000000938f0632 refcount:0 mapcount:-128 mapping:0000000000000000 index:0x0 pfn:0x11f65a
[ 32.449605] flags: 0x8000000000000000()
[ 32.450421] raw: 8000000000000000 ffffffff825b0148 ffffea00045ae988 0000000000000000
[ 32.451795] raw: 0000000000000000 0000000000000001 00000000ffffff7f 0000000000000000
[ 32.452999] page dumped because: nonzero mapcount
[ 32.453888] Modules linked in:
[ 32.454492] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.11.0-rc2+ #1976
[ 32.455695] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-1.fc33 04/01/2014
[ 32.457157] Call Trace:
[ 32.457636] <IRQ>
[ 32.457993] dump_stack+0x77/0x97
[ 32.458576] bad_page.cold+0x65/0x96
[ 32.459198] get_page_from_freelist+0x46a/0x11f0
[ 32.460008] __alloc_pages_nodemask+0x10a/0x2b0
[ 32.460794] mt7601u_rx_tasklet+0x651/0x720
[ 32.461505] tasklet_action_common.constprop.0+0x6b/0xd0
[ 32.462343] __do_softirq+0x152/0x46c
[ 32.462928] asm_call_irq_on_stack+0x12/0x20
[ 32.463610] </IRQ>
[ 32.463953] do_softirq_own_stack+0x5b/0x70
[ 32.464582] irq_exit_rcu+0x9f/0xe0
[ 32.465028] common_interrupt+0xae/0x1a0
[ 32.465536] asm_common_interrupt+0x1e/0x40
[ 32.466071] RIP: 0010:default_idle+0x18/0x20
[ 32.468981] RSP: 0018:ffffc90000077f00 EFLAGS: 00000246
[ 32.469648] RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000000000
[ 32.470550] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff81aac3dd
[ 32.471463] RBP: ffff88810022ab00 R08: 0000000000000001 R09: 0000000000000001
[ 32.472335] R10: 0000000000000046 R11: 0000000000005aa0 R12: 0000000000000000
[ 32.473235] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
[ 32.474139] ? default_idle_call+0x4d/0x200
[ 32.474681] default_idle_call+0x74/0x200
[ 32.475192] do_idle+0x1d5/0x250
[ 32.475612] cpu_startup_entry+0x19/0x20
[ 32.476114] secondary_startup_64_no_verify+0xb0/0xbb
[ 32.476765] Disabling lock debugging due to kernel taint
Fixes: c869f77d6abb ("add mt7601u driver")
Co-developed-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Acked-by: Jakub Kicinski <kubakici@wp.pl>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/62b2380c8c2091834cfad05e1059b55f945bd114.1610643952.git.lorenzo@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/net/wireless/mediatek/mt7601u/dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/net/wireless/mediatek/mt7601u/dma.c
+++ b/drivers/net/wireless/mediatek/mt7601u/dma.c
@@ -152,8 +152,7 @@ mt7601u_rx_process_entry(struct mt7601u_
if (new_p) {
/* we have one extra ref from the allocator */
- __free_pages(e->p, MT_RX_ORDER);
-
+ put_page(e->p);
e->p = new_p;
}
}
next prev parent reply other threads:[~2021-02-02 14:02 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 13:37 [PATCH 5.4 00/61] 5.4.95-rc1 review Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 01/61] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 02/61] IPv6: reply ICMP error if the first fragment dont include all headers Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 03/61] nbd: freeze the queue while were adding connections Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 04/61] ACPI: sysfs: Prefer "compatible" modalias Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 05/61] kernel: kexec: remove the lock operation of system_transition_mutex Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 06/61] ALSA: hda/realtek: Enable headset of ASUS B1400CEPE with ALC256 Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 07/61] ALSA: hda/via: Apply the workaround generically for Clevo machines Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 08/61] media: rc: ensure that uevent can be read directly after rc device register Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 09/61] ARM: dts: imx6qdl-gw52xx: fix duplicate regulator naming Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 10/61] wext: fix NULL-ptr-dereference with cfg80211s lack of commit() Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 11/61] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 12/61] s390/vfio-ap: No need to disable IRQ after queue reset Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 13/61] PM: hibernate: flush swap writer after marking Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 14/61] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 15/61] drivers: soc: atmel: add null entry at the end of at91_soc_allowed_list[] Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 16/61] btrfs: fix possible free space tree corruption with online conversion Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 17/61] KVM: x86/pmu: Fix HW_REF_CPU_CYCLES event pseudo-encoding in intel_arch_events[] Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 18/61] KVM: x86/pmu: Fix UBSAN shift-out-of-bounds warning in intel_pmu_refresh() Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 19/61] KVM: nVMX: Sync unsyncd vmcs02 state to vmcs12 on migration Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 20/61] KVM: x86: get smi pending status correctly Greg Kroah-Hartman
2021-02-02 13:37 ` [PATCH 5.4 21/61] KVM: Forbid the use of tagged userspace addresses for memslots Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 22/61] xen: Fix XenStore initialisation for XS_LOCAL Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 23/61] leds: trigger: fix potential deadlock with libata Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 24/61] arm64: dts: broadcom: Fix USB DMA address translation for Stingray Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 25/61] mt7601u: fix kernel crash unplugging the device Greg Kroah-Hartman
2021-02-02 13:38 ` Greg Kroah-Hartman [this message]
2021-02-02 13:38 ` [PATCH 5.4 27/61] drm/nouveau/svm: fail NOUVEAU_SVM_INIT ioctl on unsupported devices Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 28/61] drm/i915: Check for all subplatform bits Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 29/61] tee: optee: replace might_sleep with cond_resched Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 30/61] xen-blkfront: allow discard-* nodes to be optional Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 31/61] ARM: imx: build suspend-imx6.S with arm instruction set Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 32/61] netfilter: nft_dynset: add timeout extension to template Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 33/61] xfrm: Fix oops in xfrm_replay_advance_bmp Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 34/61] xfrm: fix disable_xfrm sysctl when used on xfrm interfaces Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 35/61] selftests: xfrm: fix test return value override issue in xfrm_policy.sh Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 36/61] xfrm: Fix wraparound in xfrm_policy_addr_delta() Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 37/61] arm64: dts: ls1028a: fix the offset of the reset register Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 38/61] ARM: dts: imx6qdl-kontron-samx6i: fix i2c_lcd/cam default status Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 39/61] firmware: imx: select SOC_BUS to fix firmware build Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 40/61] RDMA/cxgb4: Fix the reported max_recv_sge value Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 41/61] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib skl_tplg_complete Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 42/61] pNFS/NFSv4: Fix a layout segment leak in pnfs_layout_process() Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 43/61] iwlwifi: pcie: use jiffies for memory read spin time limit Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 44/61] iwlwifi: pcie: reschedule in long-running memory reads Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 45/61] mac80211: pause TX while changing interface type Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 46/61] i40e: acquire VSI pointer only after VF is initialized Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 47/61] igc: fix link speed advertising Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 48/61] net/mlx5: Fix memory leak on flow table creation error flow Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 49/61] net/mlx5e: E-switch, Fix rate calculation for overflow Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 50/61] net/mlx5e: Reduce tc unsupported key print level Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 51/61] can: dev: prevent potential information leak in can_fill_info() Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 52/61] nvme-multipath: Early exit if no path is available Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 53/61] selftests: forwarding: Specify interface when invoking mausezahn Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 54/61] iommu/vt-d: Gracefully handle DMAR units with no supported address widths Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 55/61] iommu/vt-d: Dont dereference iommu_device if IOMMU_API is not built Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 56/61] rxrpc: Fix memory leak in rxrpc_lookup_local Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 57/61] NFC: fix resource leak when target index is invalid Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 58/61] NFC: fix possible resource leak Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 59/61] ASoC: topology: Fix memory corruption in soc_tplg_denum_create_values() Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 60/61] team: protect features update by RCU to avoid deadlock Greg Kroah-Hartman
2021-02-02 13:38 ` [PATCH 5.4 61/61] tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN Greg Kroah-Hartman
2021-02-02 20:21 ` [PATCH 5.4 00/61] 5.4.95-rc1 review Jon Hunter
2021-02-03 3:16 ` Naresh Kamboju
2021-02-03 15:38 ` Shuah Khan
2021-02-03 20:42 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202132947.567675654@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=kubakici@wp.pl \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).