From: Wayne Lin <Wayne.Lin@amd.com>
To: <dri-devel@lists.freedesktop.org>
Cc: <lyude@redhat.com>, <stable@vger.kernel.org>,
<Nicholas.Kazlauskas@amd.com>, <harry.wentland@amd.com>,
<jerry.zuo@amd.com>, <eryk.brol@amd.com>, <qingqing.zhuo@amd.com>,
Wayne Lin <Wayne.Lin@amd.com>
Subject: [PATCH 2/2] drm/dp_mst: Set CLEAR_PAYLOAD_ID_TABLE as broadcast
Date: Mon, 22 Feb 2021 12:00:27 +0800 [thread overview]
Message-ID: <20210222040027.23505-3-Wayne.Lin@amd.com> (raw)
In-Reply-To: <20210222040027.23505-1-Wayne.Lin@amd.com>
[Why & How]
According to DP spec, CLEAR_PAYLOAD_ID_TABLE is a path broadcast request
message and current implementation is incorrect. Fix it.
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/drm_dp_mst_topology.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 713ef3b42054..6d73559046e5 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -1072,6 +1072,7 @@ static void build_clear_payload_id_table(struct drm_dp_sideband_msg_tx *msg)
req.req_type = DP_CLEAR_PAYLOAD_ID_TABLE;
drm_dp_encode_sideband_req(&req, msg);
+ msg->path_msg = true;
}
static int build_enum_path_resources(struct drm_dp_sideband_msg_tx *msg,
@@ -2722,7 +2723,8 @@ static int set_hdr_from_dst_qlock(struct drm_dp_sideband_msg_hdr *hdr,
req_type = txmsg->msg[0] & 0x7f;
if (req_type == DP_CONNECTION_STATUS_NOTIFY ||
- req_type == DP_RESOURCE_STATUS_NOTIFY)
+ req_type == DP_RESOURCE_STATUS_NOTIFY ||
+ req_type == DP_CLEAR_PAYLOAD_ID_TABLE)
hdr->broadcast = 1;
else
hdr->broadcast = 0;
--
2.17.1
next prev parent reply other threads:[~2021-02-22 4:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 4:00 [PATCH 0/2] Set CLEAR_PAYLOAD_ID_TABLE as broadcast request Wayne Lin
2021-02-22 4:00 ` [PATCH 1/2] drm/dp_mst: Revise broadcast msg lct & lcr Wayne Lin
2021-02-22 17:02 ` Ville Syrjälä
2021-02-22 17:09 ` Ville Syrjälä
2021-02-23 5:32 ` Lin, Wayne
2021-02-23 13:26 ` Ville Syrjälä
2021-02-24 9:47 ` Lin, Wayne
2021-02-22 4:00 ` Wayne Lin [this message]
2021-02-22 17:00 ` [PATCH 2/2] drm/dp_mst: Set CLEAR_PAYLOAD_ID_TABLE as broadcast Ville Syrjälä
2021-02-23 5:32 ` Lin, Wayne
2021-02-23 13:21 ` Ville Syrjälä
2021-02-24 18:06 ` [PATCH 0/2] Set CLEAR_PAYLOAD_ID_TABLE as broadcast request Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222040027.23505-3-Wayne.Lin@amd.com \
--to=wayne.lin@amd.com \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eryk.brol@amd.com \
--cc=harry.wentland@amd.com \
--cc=jerry.zuo@amd.com \
--cc=lyude@redhat.com \
--cc=qingqing.zhuo@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox